-
-
Notifications
You must be signed in to change notification settings - Fork 141
Fix/session storage redis #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KumarADITHYA123
wants to merge
6
commits into
AOSSIE-Org:main
Choose a base branch
from
KumarADITHYA123:fix/session-storage-redis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d90ccf
feat: Dockerize GitHub MCP server and optimize build
KumarADITHYA123 c17b599
fix: Apply remaining CodeRabbit fixes - curl, torch removal, SUPABASE…
KumarADITHYA123 bb137e7
feat(auth): replace in-memory session storage with Redis
KumarADITHYA123 e382d1d
fix: address coderabbit review (security, race conditions, docker)
KumarADITHYA123 559712c
fix: refine redis masking, error handling, and docker env vars
KumarADITHYA123 79cdeb0
fix: resolve all coderabbit review comments (redis masking, race cond…
KumarADITHYA123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import redis.asyncio as redis | ||
| import asyncio | ||
| from app.core.config import settings | ||
| import logging | ||
| from typing import Optional | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| class RedisClient: | ||
| _instance: Optional[redis.Redis] = None | ||
| _lock = asyncio.Lock() | ||
|
|
||
| @classmethod | ||
| async def get_client(cls) -> redis.Redis: | ||
| if cls._instance is None: | ||
| async with cls._lock: | ||
| if cls._instance is None: | ||
| # Mask credentials for logging | ||
| log_url = settings.redis_url | ||
| if "@" in log_url: | ||
| try: | ||
| schema, rest = log_url.split("://", 1) | ||
| userinfo, sep, host = rest.rpartition("@") | ||
| if sep: | ||
| log_url = f"{schema}://****:****@{host}" | ||
| else: | ||
| log_url = f"{schema}://****:****@..." | ||
| except ValueError: | ||
| log_url = "redis://****:****@..." | ||
|
|
||
| logger.info(f"Initializing Redis client connecting to {log_url}") | ||
| cls._instance = redis.from_url( | ||
| settings.redis_url, | ||
| encoding="utf-8", | ||
| decode_responses=True | ||
| ) | ||
| return cls._instance | ||
|
|
||
| @classmethod | ||
| async def close(cls): | ||
| if cls._instance: | ||
| await cls._instance.close() | ||
| cls._instance = None | ||
| logger.info("Redis client closed.") | ||
|
|
||
| async def get_redis_client() -> redis.Redis: | ||
| """Dependency to get the Redis client instance.""" | ||
| return await RedisClient.get_client() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.