Skip to content

fix overflow bug cause 2 expanded in the same column#804

Open
mahmoudr80 wants to merge 1 commit intoAOSSIE-Org:masterfrom
mahmoudr80:add_chapter_screen_overflow
Open

fix overflow bug cause 2 expanded in the same column#804
mahmoudr80 wants to merge 1 commit intoAOSSIE-Org:masterfrom
mahmoudr80:add_chapter_screen_overflow

Conversation

@mahmoudr80
Copy link
Copy Markdown

@mahmoudr80 mahmoudr80 commented Mar 28, 2026

Description

There are 2 Expanded widgets in the same column in the add_chapter_screen, so there is an overflow
Fixes # (issue)
Replace one Expanded with a Flexible widget

Type of change

Please delete options that are not relevant.

  • [o] Bug fix (non-breaking CHANGE which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

I used multiple emulator to test this bug

Please include screenshots below if applicable.

Checklist:

  • [o] My code follows the style guidelines of this project
  • [p] I have performed a self-review of my own code
  • [o] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [o] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [o] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [o] I have checked my code and corrected any misspellings

Maintainer Checklist

Summary by CodeRabbit

  • Style
    • Adjusted layout constraints for the chapters list to improve space allocation within the screen layout.

@mahmoudr80 mahmoudr80 requested a review from M4dhav as a code owner March 28, 2026 02:05
@github-actions
Copy link
Copy Markdown
Contributor

🎉 Welcome @mahmoudr80!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a43af7bd-d99f-43a0-8467-7500b981d5c5

📥 Commits

Reviewing files that changed from the base of the PR and between bf1dbe2 and 6837b03.

📒 Files selected for processing (1)
  • lib/views/screens/add_chapter_screen.dart

📝 Walkthrough

Walkthrough

A layout constraint in the add_chapter_screen was changed from Expanded to Flexible for the "newChapters" list within a Column. This resolves an overflow issue caused by having two Expanded widgets competing for flex space in the same column.

Changes

Cohort / File(s) Summary
Layout Constraint Fix
lib/views/screens/add_chapter_screen.dart
Changed Expanded widget to Flexible for the newChapters list to prevent overflow when multiple flex widgets share the same column.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two Expandeds caused quite the squeeze,
Column overflow, not at ease!
Flexible now bends with gentle grace,
Layout fixed—no more crowded space! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific bug fix: replacing two Expanded widgets with one Flexible in the same Column to resolve an overflow issue.
Linked Issues check ✅ Passed The PR successfully addresses issue #803 by replacing one Expanded widget with a Flexible widget in add_chapter_screen, directly implementing the proposed fix.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the overflow bug in add_chapter_screen; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overflow in add_chapter_screen

1 participant