Add welcome message#13
Merged
Merged
Conversation
ndenny
commented
Jun 11, 2026
ndenny
commented
Member
The welcome banner string already ends with a newline, so Fprintln appended a redundant one. Switch to Fprint to satisfy go vet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The [Y/n] prompt read from stdin but only checked that stderr was a terminal. If a request body was piped into stdin while stderr was a TTY, the prompt would consume its first line. Check stdin instead, matching the manual-code path that protects piped input. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
neil-gall
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.