Skip to content

coverity - fix issues in test_pool for coverity reported issues #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashymh merged 1 commit into from
Apr 10, 2026
Merged

coverity - fix issues in test_pool for coverity reported issues #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions test_pool/exerciser/e002.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ get_target_exer_bdf(uint32_t req_rp_bdf, uint32_t *tgt_e_bdf,
static
uint32_t
create_va_pa_mapping (uint64_t txn_va, uint64_t txn_pa,
smmu_master_attributes_t *smmu_master,
pgt_descriptor_t *pgt_desc, uint32_t req_instance,
uint32_t req_rp_bdf, uint32_t pgt_ap)
{
Expand All @@ -106,8 +105,6 @@ create_va_pa_mapping (uint64_t txn_va, uint64_t txn_pa,
uint64_t bar_value;
uint32_t old_val, new_val;

master = *smmu_master;

val_memory_set(&master, sizeof(master), 0);
val_memory_set(mem_desc_array, sizeof(mem_desc_array), 0);
mem_desc = &mem_desc_array[0];
Expand Down Expand Up @@ -244,7 +241,6 @@ check_redirected_req_validation (uint32_t req_instance, uint32_t req_rp_bdf, uin
uint32_t instance;
uint32_t num_smmus;
uint32_t status;
smmu_master_attributes_t master;
pgt_descriptor_t pgt_desc;

/* Sequence 1 : No Write Permission, Trigger a DMA Write to bar address
Expand All @@ -259,7 +255,7 @@ check_redirected_req_validation (uint32_t req_instance, uint32_t req_rp_bdf, uin

num_smmus = val_iovirt_get_smmu_info(SMMU_NUM_CTRL, 0);

status = create_va_pa_mapping(txn_va, bar_base, &master,
status = create_va_pa_mapping(txn_va, bar_base,
&pgt_desc, req_instance,
req_rp_bdf, PGT_STAGE1_AP_RO);
if (status) {
Expand All @@ -286,7 +282,7 @@ check_redirected_req_validation (uint32_t req_instance, uint32_t req_rp_bdf, uin
*/

/* Create VA-PA Mapping in SMMU with PGT permissions as Read Write */
status = create_va_pa_mapping(txn_va, bar_base, &master,
status = create_va_pa_mapping(txn_va, bar_base,
&pgt_desc, req_instance,
req_rp_bdf, PGT_STAGE1_AP_RW);
if (status) {
Expand Down
10 changes: 7 additions & 3 deletions test_pool/exerciser/e039.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static
void
payload(void)
{
char *baseptr;
char *baseptr = NULL;
uint32_t idx;
uint32_t pe_index;
uint32_t bdf;
Expand Down Expand Up @@ -101,6 +101,7 @@ payload(void)

/* Map the mmio space to ARM normal memory in MMU page tables */
for (idx = 0; idx < sizeof(ARM_NORMAL_MEM_ARRAY)/sizeof(ARM_NORMAL_MEM_ARRAY[0]); idx++) {
baseptr = NULL;
status = val_memory_ioremap((void *)e_data.bar_space.base_addr,
512,
ARM_NORMAL_MEM_ARRAY[idx], (void **)&baseptr);
Expand Down Expand Up @@ -129,6 +130,7 @@ payload(void)

/* Remove BAR mapping from MMU page tables */
val_memory_unmap(baseptr);
baseptr = NULL;
}
}
}
Expand All @@ -144,12 +146,14 @@ payload(void)
return;

test_warn_unimplemented:
val_memory_unmap(baseptr);
if (baseptr != NULL)
val_memory_unmap(baseptr);
val_set_status(pe_index, RESULT_WARNING(01));
return;

test_fail:
val_memory_unmap(baseptr);
if (baseptr != NULL)
val_memory_unmap(baseptr);
val_set_status(pe_index, RESULT_FAIL(03));
return;

Expand Down
28 changes: 15 additions & 13 deletions test_pool/gic/its004.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,22 @@ payload()
continue;
}

val_print(DEBUG,
"\n Checking ReqID-StreamID-DeviceID Association, Bdf : %x", bdf);
/* Check for stream_id & device_id */
if (curr_grp_sid_cons != (stream_id - req_id)) {
/* StreamID Constant Base Failure */
val_print(ERROR, "\n ReqID-StreamID Association Fail for Bdf : %x", bdf);
test_fail++;
}
if (!test_skip) {
val_print(DEBUG,
"\n Checking ReqID-StreamID-DeviceID Association, Bdf : %x", bdf);
/* Check for stream_id & device_id */
if (curr_grp_sid_cons != (stream_id - req_id)) {
/* StreamID Constant Base Failure */
val_print(ERROR, "\n ReqID-StreamID Association Fail for Bdf : %x", bdf);
test_fail++;
}

if (curr_grp_did_cons != (device_id - stream_id)) {
/* DeviceID Constant Base Failure */
val_print(ERROR,
"\n StreamID-DeviceID Association Fail for Bdf : %x", bdf);
test_fail++;
if (curr_grp_did_cons != (device_id - stream_id)) {
/* DeviceID Constant Base Failure */
val_print(ERROR,
"\n StreamID-DeviceID Association Fail for Bdf : %x", bdf);
test_fail++;
}
}

if (test_skip == 1)
Expand Down
8 changes: 4 additions & 4 deletions test_pool/pcie/p002.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ calculate_vf(uint32_t seg, uint32_t bdf, uint32_t sriov_base)
val_print(TRACE, "\n Number of VF's is 0x%x", num_vf);

vf_rid = pf_rid + first_vf_offset;
if (num_vf > MAX_VFS)
val_print(WARN, "\n Number of VF's present is more than 256");
if (num_vf > MAX_VFS) {
val_print(WARN, "\n Number of VF's present is more than 256. Limiting to 256 entries");
num_vf = MAX_VFS;
}

for (index = 0; index < num_vf; index++)
{
Expand All @@ -83,8 +85,6 @@ calculate_vf(uint32_t seg, uint32_t bdf, uint32_t sriov_base)
val_print(TRACE, "\n vf bdf is 0x%x", vf_bdf);
skip_rid_list[index] = vf_bdf;
vf_rid += vf_stride;
if (index > MAX_VFS)
val_print(WARN, "\n Index value is more than 255");
}
}

Expand Down
12 changes: 5 additions & 7 deletions test_pool/timer/t001.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,18 @@ static
void
payload_check_system_timer_freq()
{
uint64_t counter_freq, print_freq;
uint64_t counter_freq, print_freq = 0;
uint32_t index = val_pe_get_index_mpid(val_pe_get_mpid());
uint32_t print_mhz = 0;

/* Read CNTFRQ_EL0 register for counter frequency */
counter_freq = val_timer_get_info(TIMER_INFO_CNTFREQ, 0);

/* Convert frequency into MHz or KHz unit */
if (counter_freq != 0) {
print_freq = counter_freq/1000;
if (print_freq > 1000) {
print_freq = print_freq/1000;
print_mhz = 1;
}
print_freq = counter_freq/1000;
if (print_freq > 1000) {
print_freq = print_freq/1000;
print_mhz = 1;
}

/* Print counter frequency in DEBUG verbosity */
Expand Down
Loading