Skip to content

fix: actions/checkout overwrites download directory if after setup-solc #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ARR4N merged 2 commits into from
Sep 10, 2026
Merged

fix: actions/checkout overwrites download directory if after setup-solc #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b81537
test: reproduce bug when `actions/checkout` is later
ARR4N Sep 10, 2026
7931312
fix: download binaries to temporary directory
ARR4N Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ jobs:
with:
version: ${{matrix.solc}}

- name: Overwrite workspace
uses: actions/checkout@v5
# An old version of setup-solc downloaded the binaries to the runner
# workspace, which meant it had to be run _after_ actions/checkout to
# avoid being overwritten. This step acts as a regression test.

- name: Check version
run: solc --version | grep "${{matrix.solc}}"

Expand Down
6 changes: 3 additions & 3 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as fs from 'node:fs/promises';
import * as os from 'node:os';
import * as path from 'node:path';
import require$$0 from 'os';
import require$$0$1 from 'crypto';
Expand Down Expand Up @@ -29835,8 +29836,8 @@ try {
}
const constructURL = (fileName) => `https://binaries.soliditylang.org/${pathPrefix}/${fileName}`;
const list = (await fetch(constructURL('list.json')).then(res => res.json()));
const destDir = path.join(process.cwd(), 'setup-solc_downloads');
await fs.mkdir(destDir);
const destDir = path.join(process.env.RUNNER_TEMP ?? os.tmpdir(), 'setup-solc_downloads');
await fs.mkdir(destDir, { recursive: true });
coreExports.addPath(destDir);
for (const [version, outs] of parseVersionInputs().entries()) {
coreExports.info(`Setting up solc version ${version}`);
Expand All @@ -29850,7 +29851,6 @@ try {
console.info(`${version} at ${outs}`);
}
;
console.info(list);
}
catch (error) {
if (error instanceof Error) {
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 4 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as fs from 'node:fs/promises'
import * as fs from 'node:fs/promises';
import * as os from 'node:os';
import * as path from 'node:path';
import * as core from '@actions/core';
import * as tc from '@actions/tool-cache';
Expand Down Expand Up @@ -28,8 +29,8 @@ try {
}[];
};

const destDir = path.join(process.cwd(), 'setup-solc_downloads');
await fs.mkdir(destDir);
const destDir = path.join(process.env.RUNNER_TEMP ?? os.tmpdir(), 'setup-solc_downloads');
await fs.mkdir(destDir, { recursive: true });
core.addPath(destDir);

for (const [version, outs] of parseVersionInputs().entries()) {
Expand All @@ -52,8 +53,6 @@ try {
console.info(`${version} at ${outs}`);
};

console.info(list);

} catch (error: any) {
if (error instanceof Error) {
core.setFailed(error.message)
Expand Down
Loading