Repository navigation
Evaluate a binomial with a whole upper argument and a fractional lower one - #2211
Merged
Rafael-SOWNet merged 1 commit intoOct 29, 2026
Conversation
…r one binomial(n, k) with a whole n and a k that is not whole was left as written, and EvalNumerical threw: the gamma ratio was guarded to an n that is not an integer. It is Γ(n + 1)/(Γ(k + 1) Γ(n - k + 1)) for any n, and binomial(3, 1/2) is 32/(5 pi). For a negative whole n, a pole of Γ(n + 1), it has no value, as the node's domain condition says, and is NaN. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2211 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 302 302
Lines 67045 67048 +3
Branches 19469 19470 +1
=======================================
+ Hits 58045 58049 +4
+ Misses 4897 4896 -1
Partials 4103 4103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Rafael-SOWNet
deleted the
a-binomial-with-a-whole-upper-and-a-fractional-lower-argument-is-evaluated
branch
October 29, 2026 22:04
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
binomial(n, k)with a wholenand akthat is not whole was left as written, soEvalNumericalthrewCannotEvalException. The gamma ratio was guarded to annthat is not an integer, against what #1411 says the node does: "a k that is not whole evaluates numerically through the gamma function and has no value where n is a negative whole number".n >= 0goes through the gamma ratio as any otherndoes:binomial(3, 1/2)is32/(5 pi).n, a pole ofΓ(n + 1), has no value, as the node's domain condition already says:NaN.Found while measuring evaluation for #2195's compiled forms.
EvalNumericalbinomial(3, 1/2)CannotEvalException2.0371832715762602978…binomial(-3, 1/2)CannotEvalExceptionNaNTests: four values against mpmath to 25 digits (
binomial(3, 1/2),(0, 1/2),(4, 3/2),(3, -1/2)), andNaNat(-3, 1/2). Full suite 17903/0, interactive trio, AOT smoke 66/0, all frameworks build (on the master before #2209; the chain runs on this branch).🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura