Repository navigation
The imaginary part of a value that does not exist has none - #2257
Open
Rafael-SOWNet wants to merge 1 commit into
Open
Rafael-SOWNet wants to merge 1 commit into
Rafael-SOWNet wants to merge 1 commit into
Conversation
Im(1/0) was 0, and so was Im(arccos(pi) provided pi < 3), where Re, conj, arg, abs and floor of the same values are NaN. Imf.ImaginaryPart answered any Complex with its imaginary part, and NaN is a Real, whose imaginary part is 0. A NaN argument is now NaN, before that arm. ImaginaryPartOfNaNTest takes Im of three values that do not exist, evaluated, simplified and substituted, and four of them fail on master. Re(1/0) and the imaginary parts of 2 + 3i, 5 and -oo pin what has not changed. Im is new since 2.6.0 (#2145), where im(1/0) was the product im * (1/0), so no answer changes against it. Found by work/domaincheck. Fixes #2253. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2257 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 310 310
Lines 67790 67794 +4
Branches 19666 19666
=======================================
+ Hits 58786 58790 +4
+ Misses 4892 4891 -1
- Partials 4112 4113 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imof a value that does not exist was0.Imf.ImaginaryPartanswered anyComplexwith its imaginary part, andNaNis aReal, whose imaginary part is 0. ANaNargument is nowNaN."Im(1/0)".ToEntity().Evaled0NaN"Im(x)".ToEntity().Substitute("x", "1/0").Evaled0NaN"Im(arccos(pi) provided pi < 3)".ToEntity().Evaled0NaNRe,conj,arg,absandfloorof these were alreadyNaN.Imis new since 2.6.0 (#2145), whereim(1/0)was the productim * (1/0), so no answer changes against 2.6.0 and there is no BREAKING entry.ImaginaryPartOfNaNTest: four cases fail on master, and four that pin unchanged values pass on both. Suite 18180 passed. The F# wrapper suite, the Mcp, Terminal and InteractiveWrapper suites and the AOT smoke test pass. Found by a new workspace harness,work/domaincheck.Fixes #2253.
🤖 Generated with Claude Code