Repository navigation
The factorial and the gamma function are defined off the real line - #2260
Open
Rafael-SOWNet wants to merge 1 commit into
Open
Rafael-SOWNet wants to merge 1 commit into
Rafael-SOWNet wants to merge 1 commit into
Conversation
The factorial's condition was x in RR and (x >= 0 or not x in ZZ), which asked for a real argument as well, though i! is 0.498 - 0.155i and the only poles are the negative integers. x!/x! simplified to 1 provided x in RR and (...), which has no value at x = i, where it is 1. The condition is now x in ZZ implies x >= 0: off the integers x in ZZ is false and the implication is true. It is written as Simplify writes it, so that a quotient's not x! = 0, which Simplify reads as True under this condition, folds into it. As not (x in ZZ and x < 0) the answer carried both. ExponentialSeries.HoldsOverTheRange read the old shape to drop a factorial's condition over a summation range, and integral(floor(x) / (floor(x) + 1)!, x, 0, +oo) stopped being 1. An implication now holds over the range wherever its conclusion does. FactorialOffTheRealLineTest takes the condition at eleven points, off the real line, at poles and between them, and two simplified quotients at complex points; six fail on master. SimplifyTest's three x!/x!-shaped tests pinned the old condition, and now have the new one. Found by work/domaincheck. Part of #2256. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2260 +/- ##
==========================================
- Coverage 86.71% 86.70% -0.02%
==========================================
Files 310 310
Lines 67790 67819 +29
Branches 19666 19676 +10
==========================================
+ Hits 58786 58801 +15
- Misses 4892 4898 +6
- Partials 4112 4120 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The factorial's condition was
x in RR and (x >= 0 or not x in ZZ). That asked for a real argument as well, thoughi!is0.498 - 0.155iand the only poles are the negative integers.x!/x!simplified to an answer with no value atx = i, where it is 1.The condition is now
x in ZZ implies x >= 0: off the integersx in ZZis false, so the implication is true. It is written the waySimplifywrites it, so that a quotient'snot x! = 0, whichSimplifyreads asTrueunder this condition, folds into it. Written asnot (x in ZZ and x < 0), the answer carried both clauses."x!/x!".ToEntity().Simplify()1 provided x in RR and (x >= 0 or not x in ZZ)1 provided x in ZZ implies x >= 0"x! = 0".ToEntity().Simplify()False provided x in RR and (x >= 0 or not x in ZZ)False provided x in ZZ implies x >= 0"x!".ToEntity().DomainConditionx in RR and (x >= 0 or not x in ZZ)x in ZZ implies x >= 0ExponentialSeries.HoldsOverTheRangeread the old shape when dropping a factorial's condition over a summation range, sointegral(floor(x) / (floor(x) + 1)!, x, 0, +oo)stopped being 1. An implication now holds over the range wherever its conclusion does.FactorialOffTheRealLineTest: six cases fail on master.SimplifyTest's threex!/x!-shaped tests pinned the old condition and now have the new one. Suite 18185 passed. The F# wrapper suite, the Mcp, Terminal and InteractiveWrapper suites and the AOT smoke test pass. BoundCheck, RootCheck, CasBench, PropCheck, SimpSweep, RuleCheck, CanonCheck and Confluence are unchanged. Found bywork/domaincheck.Part of #2256.
🤖 Generated with Claude Code