Repository navigation
max and min are defined where their arguments are real - #2261
Open
Rafael-SOWNet wants to merge 1 commit into
Open
Rafael-SOWNet wants to merge 1 commit into
Rafael-SOWNet wants to merge 1 commit into
Conversation
The complex numbers are not ordered, and max and min are read over the reals, so max(i, i) is NaN and max(i, 2) is left as written. Their condition was True, and max(x, x) simplified to x, which has a value at x = i. The condition is now that both arguments are real. The node's own fold of max(a, a) and min(a, a) to a did not consult the condition, and is now a provided a in RR, simplified in place: for a number that decides it, so max(i, i) stays NaN and max(3, 3) is 3, and for a symbol it is the condition. MaxMinOffTheRealLineTest takes the condition and the value at four points, max(i, i) and min(1 + i, 1 + i), and max(x, x) and min(x, x) simplified, at i and at 3. Four of the cases fail on master. A value where the condition fails is NaN, or the node left as written. RoundMinMaxGcdTest pinned min(x, x) as x, and now has x provided x in RR, with min(3, 3) beside it. Found by work/domaincheck. Part of #2256. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2261 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 310 310
Lines 67791 67816 +25
Branches 19666 19676 +10
=======================================
+ Hits 58785 58808 +23
Misses 4893 4893
- Partials 4113 4115 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The complex numbers are not ordered, and
maxandminare read over the reals, somax(i, i)isNaNandmax(i, 2)is left as written. Their condition wasTrue, andmax(x, x)simplified tox, which has a value atx = i. The condition is now that both arguments are real. The node's own fold ofmax(a, a)toadid not consult the condition. It now givesa provided a in RR, simplified in place, somax(i, i)staysNaN,max(3, 3)is3, and a symbol keeps the condition."max(x, x)".ToEntity().Simplify()xx provided x in RR"max(x, 2)".ToEntity().DomainConditionTruex in RR"max(i, i)".ToEntity().EvaledNaNNaNMaxMinOffTheRealLineTest: four cases fail on master and four pass on both.RoundMinMaxGcdTestpinnedmin(x, x)asx, and now hasx provided x in RR. Suite 18188 passed. The F# wrapper suite, the Mcp, Terminal and InteractiveWrapper suites and the AOT smoke test pass. BoundCheck, RootCheck, CasBench, PropCheck, SimpSweep, RuleCheck, CanonCheck and Confluence are unchanged. Found bywork/domaincheck.Part of #2256.
🤖 Generated with Claude Code