Repository navigation
Compiled real and imaginary parts of a value that is not there are not there - #2312
Merged
Rafael-SOWNet merged 1 commit intoNov 1, 2026
Conversation
…t there Both compilers take Re and Im of a System.Numerics.Complex as the one part alone, so a NaN in the other part was dropped. x / x at 0 compiles to NaN + NaN i, its imaginary part to NaN with an imaginary part of 0, and the imaginary part of that to 0: Im(Im(x / x)) and Im(Re(x / x)) compiled to 0 at 0, where the interpreter, and the compiled x / x, have no value. A NaN in either part is now the whole number's, as Im of a NaN double already was. Found among work/compilesweep's findings, as Im(Im(min(x, x))) off the real line. No issue was filed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
- Coverage 86.77% 86.76% -0.01%
==========================================
Files 311 311
Lines 68199 68199
Branches 19821 19823 +2
==========================================
- Hits 59178 59174 -4
- Misses 4880 4883 +3
- Partials 4141 4142 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Rafael-SOWNet
deleted the
compiled-parts-of-a-value-that-is-not-there-are-not-there
branch
November 1, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both compilers take
ReandImof aSystem.Numerics.Complexas one part alone, so a NaN in the other part was dropped.x / xat 0 compiles toNaN + NaN i. Its imaginary part isNaNwith an imaginary part of 0, and the imaginary part of that is 0. So the compiled forms had a value where the interpreter, and the compiledx / x, have none. A NaN in either part is now the whole number's, asImof a NaNdoublealready was.x = 0Im(Im(x / x))NaN<0; 0><NaN; 0>Im(Re(x / x))NaN<0; 0><NaN; 0>Im(Im(sqrt(x) / sqrt(x)))NaN<0; 0><NaN; 0>Re(x)at1 + NaN i<1; 0><NaN; 0>work/compilesweep's findings asIm(Im(min(x, x)))off the real line. No issue was filed.ReandImfirst compiled in The conjugate, the argument, the parts and the Iverson bracket compile #2196, after 2.6.0, which refused them, so no released answer changes and there's noBREAKING-CHANGES.mdentry.Re(Im(x / x))was already NaN and stays as a control. The suite, the trio, F#, AOT and the eight harnesses pass.🤖 Generated with Claude Code