Skip to content

Leave a limit on the arctangent's cut unevaluated - #2334

Merged
Rafael-SOWNet merged 1 commit into
masterfrom
an-arctangent-arriving-on-its-cut-is-not-read-off-its-principal-value
Nov 2, 2026
Merged

Rafael-SOWNet merged 1 commit into
masterfrom
an-arctangent-arriving-on-its-cut-is-not-read-off-its-principal-value

Conversation

@Rafael-SOWNet

Copy link
Copy Markdown
Member

Found by limitcheck at seed 11. No issue was filed.

The arctangent's cut is the imaginary axis past i and -i, and its principal value there is the limit from one side only. A limit whose arctan argument arrived on the cut was read off that value without asking which side the argument came from.

values tend to 2.6.0 and master this PR
arctan(log(2, x)) at -1+ -pi/2 + 0.224i pi/2 + 0.224i unevaluated
arctan(2i + x) at 0- -pi/2 + 0.549i pi/2 + 0.549i unevaluated

Such a limit is now declined, as one on the logarithm's cut is (#2266). That includes a limit from the side where the principal value is right: telling the sides apart needs the sign of the argument's real part along the approach, which this check doesn't have.

limitcheck:

  • at seeds 1 and 7, the findings and counts are master's;
  • at seed 11, the arctan row is gone, and 8 more limits are declined.

Tests: both cut cases in LimitOnAnArctangentsCutTest fail on master, and a control off the cut passes. There is a BREAKING entry, A limit on an arctangent's cut is not read off the principal value.

🤖 Generated with Claude Code

The arctangent's cut is the imaginary axis past i and -i, and its
principal value there is the limit from one side only. A limit whose
arctan argument arrived on the cut was read off that value without asking
which side the argument came from: log(2, x) comes to i pi / ln(2) from
the left half-plane as x comes up to -1, so arctan(log(2, x)) tends to
-pi/2 + 0.224i there, and the answer was pi/2 + 0.224i. arctan(2i + x)
at 0- was arctan(2i), pi/2 + 0.549i, where the values tend to -pi/2.

Such a limit is now declined, as one on the logarithm's cut is (#2266),
from the side where the principal value is right as well.

limitcheck at seeds 1 and 7: the findings and counts are master's. At
seed 11 the arctan row is gone, and 8 more limits are declined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Rafael-SOWNet Rafael-SOWNet added this to the 2.7.0 milestone Nov 2, 2026
@Rafael-SOWNet Rafael-SOWNet moved this from Todo to In review in AngouriMath Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.75%. Comparing base (93a52f0) to head (f2cec95).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   86.75%   86.75%   -0.01%     
==========================================
  Files         312      312              
  Lines       68447    68454       +7     
  Branches    19909    19910       +1     
==========================================
+ Hits        59379    59384       +5     
- Misses       4908     4913       +5     
+ Partials     4160     4157       -3     
Flag Coverage Δ
cpp 37.77% <ø> (ø)
csharp 87.29% <100.00%> (-0.01%) ⬇️
fsharp 32.97% <ø> (ø)
interactive 40.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ath/Functions/Continuous/Limits/Transformations.cs 87.37% <100.00%> (+0.15%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rafael-SOWNet
Rafael-SOWNet merged commit a7785bc into master Nov 2, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in AngouriMath Nov 2, 2026
@Rafael-SOWNet
Rafael-SOWNet deleted the an-arctangent-arriving-on-its-cut-is-not-read-off-its-principal-value branch November 2, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant