Repository navigation
Install the GA .NET 10 SDK in CI, not the stale preview - #2367
Merged
Merged
Conversation
Every workflow asked setup-dotnet for '10.x' with dotnet-quality 'preview', left from before .NET 10 was released. That quality now resolves to 10.0.100-rc.2, so the SDK that builds is whichever newer one the runner image carries, and its ILCompiler is 10.0.13. GHSA-p3jp-9v83-76w9 (published 2026-11-03) covers ILCompiler < 10.0.14, and the C++ export publishes with PublishAot and treats NU1903 as an error, so the three AngouriMathCpp jobs fail at restore on every run since. The default GA quality resolves '10.x' to SDK 10.0.403, which carries 10.0.14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2367 +/- ##
=======================================
Coverage 86.78% 86.78%
=======================================
Files 312 312
Lines 68861 68861
Branches 20066 20066
=======================================
+ Hits 59761 59762 +1
+ Misses 4911 4909 -2
- Partials 4189 4190 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three
AngouriMathCppjobs started failing at restore today, on #2366 and on every run after it:The advisory came out on 2026-11-03 and is patched in 10.0.14. The workflows pinned no version. Each asked
setup-dotnetfor10.xwithdotnet-quality: 'preview', which dates from before .NET 10 shipped. That quality now resolves to10.0.100-rc.2.25502.107, so the build ran on the newer SDK already on the runner image, and that SDK carries ILCompiler 10.0.13. Master's C++ build at 09:41 passed. The advisory reached the runner between that run and #2366's at 10:22.This drops
dotnet-quality: 'preview'from all 21 setup steps in 18 workflows.10.xat the default GA quality resolves to SDK 10.0.403, which carries 10.0.14. The diff only removes those lines.🤖 Generated with Claude Code