Repository navigation
Read the limit of a modulus as the quotient or product of moduli - #2371
Merged
Rafael-SOWNet merged 1 commit intoNov 4, 2026
Merged
Conversation
abs(1/x^pi) at 0 was NaN, the claim that the limit does not exist, where it is +oo from both sides, as 1/abs(x)^pi is. The modulus took its argument's limit and nothing else. To the left of 0, x^pi is complex, so the sign 1/x^pi's divisor vanishes with could not be read: that side had no limit, and the two-sided limit was NaN. The same on 2.6.0. Where the argument's limit gives the modulus no value, the modulus of a quotient is now read as the quotient of the moduli, and of a product as the product. Both hold for complex values. Read that way, the divisor vanishes from above, which the vanishing-divisor reading already answers. abs(log(cos(x), -1)) at 0, which is pi / abs(ln(cos(x))), is +oo for the same reason. limitcheck at DEPTH=3, 21 seeds 14-51, master against this: 3 more compared over 2 seeds, the two NaNs above answered, and nothing else changed. Suite 18988 passed, AOT and the eight harnesses clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2371 +/- ##
==========================================
+ Coverage 86.76% 86.77% +0.01%
==========================================
Files 312 312
Lines 68897 68908 +11
Branches 20078 20081 +3
==========================================
+ Hits 59777 59798 +21
+ Misses 4923 4912 -11
- Partials 4197 4198 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
Merged without the three macOS jobs. They were cancelled before they started ("The job was not acquired by Runner of type hosted even after multiple attempts"), the same macOS arm64 outage as on #2368–#2370. In their place:
|
Rafael-SOWNet
deleted the
fix/a-modulus-of-a-quotient-is-a-quotient-of-moduli
branch
November 4, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abs(1/x^pi)at 0 wasNaN, the claim that the limit does not exist. It is+oofrom both sides, as1/abs(x)^piis.The modulus took its argument's limit and nothing else. To the left of 0,
x^piis complex, so there was no reading of which sign1/x^pi's divisor vanishes with. That side had no limit, and the two-sided limit wasNaN. 2.6.0 gives the same results.Now, where the argument's limit gives the modulus no value, the modulus of a quotient is read as the quotient of the moduli, and of a product as the product. Both hold for complex values. Read that way, the divisor vanishes from above, and the existing vanishing-divisor reading answers it. A modulus that already has a limit as written keeps it, and the tests pin three of those.
abs(1/x^pi)NaN; unevaluated from the left+ooabs(1/sqrt(x))NaN+ooabs(2/x^(3/2))from the left+ooabs(log(cos(x), -1)), which is π/|ln cos x|NaN; unevaluated from the right+ooMeasured
DEPTH=3on 21 seeds (14 to 51), master against this branch: 3 more rows compared, across 2 seeds. Those are the two NaNs above,abs(1/x^pi)at seed 51 andabs(log(cos(x), -1))at seed 41. No other row changed.Recorded in BREAKING-CHANGES.md.
🤖 Generated with Claude Code