-
Notifications
You must be signed in to change notification settings - Fork 11
feat(component-header-footer): add multi column dropdown, limit mega menu width #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scott-williams-az
wants to merge
10
commits into
dev
Choose a base branch
from
uds-1875d
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ac07b02
feat(component-header-footer): add multi column dropdown, limit mega …
scott-williams-az 9d3466e
linting
scott-williams-az e6ad7e8
fix resolving merge
scott-williams-az d98eb0d
feat(component-header-footer): adjust dropdown open/close and height
scott-williams-az 1b096e5
feat(component-header-footer): mobile styles
scott-williams-az c5e43a9
feat(component-header-footer): add style that was removed
scott-williams-az d85bde9
feat(component-header-footer): adjustments
scott-williams-az 182fccd
fix(component-header-footer): adjustments
scott-williams-az 3b629b1
feat(component-header-footer): adjustments
scott-williams-az bdac62c
fix: remove merge syntax remnant
scott-williams-az File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scott-williams-az
Do we need a .map() function? Im asking because it returns an array, we may can solve this using reduce or forEach. For instance, something like this:
onst cols = items.reduce((sum, lists) => sum + (lists[0]?.span || 1), 0);If not, can we check if lists[0] is not crashing if an empty array is passed in items?