remove deprecated spring module and related components#821
Open
halotukozak wants to merge 1 commit intomasterfrom
Open
remove deprecated spring module and related components#821halotukozak wants to merge 1 commit intomasterfrom
spring module and related components#821halotukozak wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the deprecated commons-spring submodule and its associated Spring/HOCON integration utilities, along with related test sources and resources, and cleans up build + README references.
Changes:
- Deletes the
springsubproject sources (e.g.,HoconBeanDefinitionReader,HoconType,ScalaDefaultValuesInjector,AttrNames) and its tests/resources. - Updates SBT build definition to drop the
springsubproject and Spring dependency version. - Updates
README.mdto remove the deprecatedcommons-springmodule entry.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spring/src/test/scala/com/avsystem/commons/spring/XmlPlayground.scala | Removes deprecated Spring/HOCON playground code. |
| spring/src/test/scala/com/avsystem/commons/spring/Playground.scala | Removes deprecated HOCON playground code. |
| spring/src/test/scala/com/avsystem/commons/spring/HoconBeanDefinitionReaderTest.scala | Removes Spring/HOCON reader test suite and test beans. |
| spring/src/test/resources/testBean.conf | Removes Spring/HOCON bean-definition test config. |
| spring/src/test/resources/conditionalsNested.conf | Removes conditional-includes test config. |
| spring/src/test/resources/conditionalsEnabled.conf | Removes conditional-includes test config (enabled case). |
| spring/src/test/resources/conditionalsDisabled.conf | Removes conditional-includes test config (disabled case). |
| spring/src/test/resources/conditionalInclude.conf | Removes conditional include file used by tests. |
| spring/src/test/resources/beans.xml | Removes XML bean-definition fixture. |
| spring/src/test/resources/beans.conf | Removes HOCON bean-definition fixture. |
| spring/src/test/resources/bean2.conf | Removes auxiliary bean fixture. |
| spring/src/test/resources/bean1.conf | Removes auxiliary bean fixture. |
| spring/src/main/scala/com/avsystem/commons/spring/package.scala | Removes package object constants used for deprecation messaging. |
| spring/src/main/scala/com/avsystem/commons/spring/ScalaDefaultValuesInjector.scala | Removes Spring BeanDefinitionRegistryPostProcessor implementation. |
| spring/src/main/scala/com/avsystem/commons/spring/HoconType.scala | Removes HOCON-to-type decoding typeclass and instances. |
| spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala | Removes the deprecated Spring bean definition reader implementation. |
| spring/src/main/scala/com/avsystem/commons/spring/AttrNames.scala | Removes Spring/HOCON attribute key definitions and mappings. |
| project/Commons.scala | Drops spring subproject and its dependency/version wiring from the build. |
| README.md | Removes documentation of deprecated commons-spring module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.