Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates the Sam macro helper and migrates several Java/Guava interop helpers to rely on Scala’s native SAM conversions instead.
Changes:
- Deprecated
com.avsystem.commons.misc.Sam. - Replaced
Sam[...]usages in Java/Guava interop helpers with native SAM-based lambdas. - Updated some imports while removing
Samreferences.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| core/src/main/scala/com/avsystem/commons/misc/Sam.scala | Deprecates Sam to steer users toward native SAM conversion. |
| core/src/main/scala/com/avsystem/commons/jiop/JBasicUtils.scala | Replaces Sam-based helpers with native SAM lambdas for Runnable/Callable/Comparator. |
| core/jvm/src/main/scala/com/avsystem/commons/jiop/JFunctionUtils.scala | Replaces Sam-based conversions with explicit lambdas for java.util.function interfaces. |
| core/jvm/src/main/scala/com/avsystem/commons/jiop/GuavaInterop.scala | Replaces Sam usage with native SAM lambdas for Guava functional interfaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ddworak
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala has native SAM conversion support since 2.11.x. One less macro to migrate