deprecate OrderingOps and some IteratorOps#829
Open
halotukozak wants to merge 1 commit intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR deprecates a few SharedExtensions utilities that are redundant on Scala 2.13 because equivalent member methods exist in the standard library, making these extension methods effectively unused by normal method selection.
Changes:
- Deprecated the
SharedExtensions.orderingOpsimplicit conversion. - Deprecated
IteratorOps.distinctByandIteratorOps.distinct. - Deprecated
OrderingOps.orElseandOrderingOps.orElseBy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -825,13 +828,15 @@ object SharedExtensionsUtils extends SharedExtensions { | |||
| } | |||
|
|
|||
Comment on lines
751
to
771
| @@ -765,6 +767,7 @@ object SharedExtensionsUtils extends SharedExtensions { | |||
| } else throw new NoSuchElementException | |||
| } | |||
|
|
|||
| @deprecated("Scala 2.13 has native scala.collection.Iterator.distinct implementation", "2.27.0") | |||
| def distinct: Iterator[A] = distinctBy(identity) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These extensions won't be taken either way. The compiler always picks the member methods