Skip to content

fix progress saving#68

Merged
Aatricks merged 2 commits into
mainfrom
claude/fix-bulk-download-status-Mhax0
May 23, 2026
Merged

fix progress saving#68
Aatricks merged 2 commits into
mainfrom
claude/fix-bulk-download-status-Mhax0

Conversation

@Aatricks
Copy link
Copy Markdown
Owner

This pull request updates the detekt-baseline.xml file to reflect recent changes in the codebase, primarily by adding new code smell suppressions and updating function signatures to match refactored or newly introduced methods. The changes ensure that static analysis tools like Detekt do not raise issues for complex conditions, cyclomatic complexity, and function naming in the updated or new functions.

Key updates include:

New and Updated Suppressions for Complex Conditions and Cyclomatic Complexity

  • Added suppressions for several new complex conditions in HtmlParser.kt and ImageIntegrity.kt, as well as new or refactored methods in EpubContentLoader.kt and WebContentLoader.kt. These reflect new logic introduced for image parsing and integrity checks, as well as EPUB and web content handling.
  • Updated cyclomatic complexity suppressions for newly added or renamed functions, such as calculateInitialPosition, updateScrollPosition, and persistLifecycleProgress in ReaderProgressController.kt and ReaderViewModel.kt.

Function Naming and Signature Updates

  • Updated function naming suppressions to match new or refactored function signatures, including changes to parameters for composable functions like ChapterSummaryDropdown, ReaderScreen, and EdgeHintChip. This ensures Detekt does not flag the new signatures after refactoring. [1] [2] [3]

Removal of Obsolete Suppressions

  • Removed suppressions for functions and conditions that no longer exist in the codebase, such as certain methods in WebContentLoader.kt and EpubContentLoader.kt. [1] [2]

Long Method and Large Class Suppressions

  • Updated long method suppressions to match refactored function signatures, particularly for ChapterSummaryDropdown.

These changes keep the static analysis baseline in sync with the code, reducing noise from known or accepted code smells and ensuring that new issues are more visible.

Aatricks added 2 commits May 22, 2026 23:32
Treat terminal (end-of-chapter) samples as explicit intent and use the
PAGED_POSITION_ITEM_SIZE_PX sentinel to bypass layout-stability checks.
Propagate a forcePersist flag through updateReadingProgress and mark
seek-bar drags as user-dragged so seeks persist even when images are
unmeasured.
@Aatricks Aatricks self-assigned this May 23, 2026
@Aatricks Aatricks merged commit 905ff97 into main May 23, 2026
4 checks passed
@Aatricks Aatricks deleted the claude/fix-bulk-download-status-Mhax0 branch May 23, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant