fix progress saving#68
Merged
Merged
Conversation
Treat terminal (end-of-chapter) samples as explicit intent and use the PAGED_POSITION_ITEM_SIZE_PX sentinel to bypass layout-stability checks. Propagate a forcePersist flag through updateReadingProgress and mark seek-bar drags as user-dragged so seeks persist even when images are unmeasured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
detekt-baseline.xmlfile to reflect recent changes in the codebase, primarily by adding new code smell suppressions and updating function signatures to match refactored or newly introduced methods. The changes ensure that static analysis tools like Detekt do not raise issues for complex conditions, cyclomatic complexity, and function naming in the updated or new functions.Key updates include:
New and Updated Suppressions for Complex Conditions and Cyclomatic Complexity
HtmlParser.ktandImageIntegrity.kt, as well as new or refactored methods inEpubContentLoader.ktandWebContentLoader.kt. These reflect new logic introduced for image parsing and integrity checks, as well as EPUB and web content handling.calculateInitialPosition,updateScrollPosition, andpersistLifecycleProgressinReaderProgressController.ktandReaderViewModel.kt.Function Naming and Signature Updates
ChapterSummaryDropdown,ReaderScreen, andEdgeHintChip. This ensures Detekt does not flag the new signatures after refactoring. [1] [2] [3]Removal of Obsolete Suppressions
WebContentLoader.ktandEpubContentLoader.kt. [1] [2]Long Method and Large Class Suppressions
ChapterSummaryDropdown.These changes keep the static analysis baseline in sync with the code, reducing noise from known or accepted code smells and ensuring that new issues are more visible.