Repository navigation
feat(commit): let an agent author stand #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AbysmalBiscuit
merged 5 commits into
main
from
402-feat-commit-let-an-agent-author-stand
Oct 18, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1fea9b3
feat(commit): let an agent author stand
AbysmalBiscuit f4c1b42
fix(commit): check the author git records
AbysmalBiscuit 336bdaf
fix(commit): keep always coauthors required
AbysmalBiscuit e7cc69d
docs(vcs): state author lookup order
AbysmalBiscuit 0cc071d
fix(commit): keep git whitespace cleanup
AbysmalBiscuit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an agent caller has coauthors required for agents and no --coauthor, devkit commit exempts the commit only if VersionControl::author returns a GitHub bot, Claude, or Codex address. GitBackend::author returns Ok(None) whenever exactly one of GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL is set, even when the set half is a bot email and the missing half is filled from author.* or user.*. Git itself does not do that: a set GIT_AUTHOR_EMAIL overrides the email, and the unset name comes from GIT_AUTHOR_NAME, then author.name, then user.name (and the reverse for a name-only pair). A harness that exports only GIT_AUTHOR_EMAIL=261865991+grok-by-xai[bot]@users.noreply.github.com, or only GIT_AUTHOR_NAME, while the other half lives in git config, therefore gets "devkit commit needs --coauthor=... (required for agents)" and HEAD stays put, even though the commit git would record is already that agent. The same lookup is what the skill text calls the address the commit would record. Resolve each half the way git does, and return Ok(None) only when that half is still unset or blank.