build: openjph auto-build#5247
Open
lgritz wants to merge 3 commits into
Open
Conversation
Add scripts for openjph auto-build when not found (and OpenImageIO_BUILD_MISSING_DEPS specifies it, or "all"). Since we can build it when missing, take away the various missing openjph allowances from our CI; auto-build when needed for all variants. Build openjph 0.28.1 when missing. That's not the very latest, but I found 0.29.0 had broken build with certain gcc versions. The authors are aware and it will be fixed soon. More thorough exception catching for openjph in our jpeg2000input.cpp. When I compile openjph with clang (including icx), I get some runtime exceptions. Not when I build it with gcc! I don't have the time or inclination to investigate why, so for our CI, rig it to build openjph with gcc even when I'm building OIIO with clang/icx. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scripts for openjph auto-build when not found (and OpenImageIO_BUILD_MISSING_DEPS specifies it, or "all"). Build openjph 0.30.1 when missing.
Since we can build it when missing, take away the various missing openjph allowances from our CI; auto-build when needed for all variants.
More thorough exception catching for openjph in our jpeg2000input.cpp.
When I compile openjph with clang (including icx), I get some runtime exceptions. Not when I build it with gcc! I don't have the time or inclination to investigate why, so for our CI, rig it to build openjph with gcc even when I'm building OIIO with clang/icx.