Skip to content

Make OfxExport export a symbol on GCC and Clang, and use it in the examples #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garyo merged 4 commits into from
Sep 23, 2026
+41 −163
Merged

Make OfxExport export a symbol on GCC and Clang, and use it in the examples #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f176d92
Make OfxExport export a symbol on GCC and Clang, and use it in the ex…
garyo Sep 22, 2026
95d798c
Merge branch 'main' into fix/ofxexport-visibility
garyo Sep 22, 2026
4f0909a
Drop the redundant OfxExport from the example definitions, fix OfxSet…
garyo Sep 23, 2026
edaecb4
Guide: define the example entry points without an EXPORT macro
garyo Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions Documentation/sources/Guide/Code/Example1/basics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@
// the one OFX header we need, it includes the others necessary
#include "ofxImageEffect.h"

#if defined __APPLE__ || defined __linux__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

////////////////////////////////////////////////////////////////////////////////
// macro to write a labelled message to stderr with
#ifdef _WIN32
Expand Down Expand Up @@ -314,7 +306,7 @@ static OfxPlugin effectPluginStruct =
// this binary.
//
// This will be the first function called by the host.
EXPORT int OfxGetNumberOfPlugins(void)
int OfxGetNumberOfPlugins(void)
{
return 1;
}
Expand All @@ -325,7 +317,7 @@ EXPORT int OfxGetNumberOfPlugins(void)
// this binary.
//
// This will be called multiple times by the host, once for each plugin present.
EXPORT OfxPlugin * OfxGetPlugin(int nth)
OfxPlugin * OfxGetPlugin(int nth)
{
if(nth == 0)
return &effectPluginStruct;
Expand Down
12 changes: 2 additions & 10 deletions Documentation/sources/Guide/Code/Example2/invert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@
// the one OFX header we need, it includes the others necessary
#include "ofxImageEffect.h"

#if defined __APPLE__ || defined __linux__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

////////////////////////////////////////////////////////////////////////////////
// macro to write a labelled message to stderr with
#ifdef _WIN32
Expand Down Expand Up @@ -440,7 +432,7 @@ static OfxPlugin effectPluginStruct =
// this binary.
//
// This will be the first function called by the host.
EXPORT int OfxGetNumberOfPlugins(void)
int OfxGetNumberOfPlugins(void)
{
return 1;
}
Expand All @@ -451,7 +443,7 @@ EXPORT int OfxGetNumberOfPlugins(void)
// this binary.
//
// This will be called multiple times by the host, once for each plugin present.
EXPORT OfxPlugin * OfxGetPlugin(int nth)
OfxPlugin * OfxGetPlugin(int nth)
{
if(nth == 0)
return &effectPluginStruct;
Expand Down
12 changes: 2 additions & 10 deletions Documentation/sources/Guide/Code/Example3/gain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@
// the one OFX header we need, it includes the others necessary
#include "ofxImageEffect.h"

#if defined __APPLE__ || defined __linux__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

////////////////////////////////////////////////////////////////////////////////
// macro to write a labelled message to stderr with
#ifdef _WIN32
Expand Down Expand Up @@ -662,7 +654,7 @@ static OfxPlugin effectPluginStruct =
// this binary.
//
// This will be the first function called by the host.
EXPORT int OfxGetNumberOfPlugins(void)
int OfxGetNumberOfPlugins(void)
{
return 1;
}
Expand All @@ -673,7 +665,7 @@ EXPORT int OfxGetNumberOfPlugins(void)
// this binary.
//
// This will be called multiple times by the host, once for each plugin present.
EXPORT OfxPlugin * OfxGetPlugin(int nth)
OfxPlugin * OfxGetPlugin(int nth)
{
if(nth == 0)
return &effectPluginStruct;
Expand Down
12 changes: 2 additions & 10 deletions Documentation/sources/Guide/Code/Example4/saturation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@
// the one OFX header we need, it includes the others necessary
#include "ofxImageEffect.h"

#if defined __APPLE__ || defined __linux__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

////////////////////////////////////////////////////////////////////////////////
// macro to write a labelled message to stderr with
#ifdef _WIN32
Expand Down Expand Up @@ -793,7 +785,7 @@ static OfxPlugin effectPluginStruct =
// this binary.
//
// This will be the first function called by the host.
EXPORT int OfxGetNumberOfPlugins(void)
int OfxGetNumberOfPlugins(void)
{
return 1;
}
Expand All @@ -804,7 +796,7 @@ EXPORT int OfxGetNumberOfPlugins(void)
// this binary.
//
// This will be called multiple times by the host, once for each plugin present.
EXPORT OfxPlugin * OfxGetPlugin(int nth)
OfxPlugin * OfxGetPlugin(int nth)
{
if(nth == 0)
return &effectPluginStruct;
Expand Down
12 changes: 2 additions & 10 deletions Documentation/sources/Guide/Code/Example5/circle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@
// the one OFX header we need, it includes the others necessary
#include "ofxImageEffect.h"

#if defined __APPLE__ || defined __linux__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

////////////////////////////////////////////////////////////////////////////////
// macro to write a labelled message to stderr with
#ifdef _WIN32
Expand Down Expand Up @@ -992,7 +984,7 @@ static OfxPlugin effectPluginStruct =
// this binary.
//
// This will be the first function called by the host.
EXPORT int OfxGetNumberOfPlugins(void)
int OfxGetNumberOfPlugins(void)
{
return 1;
}
Expand All @@ -1003,7 +995,7 @@ EXPORT int OfxGetNumberOfPlugins(void)
// this binary.
//
// This will be called multiple times by the host, once for each plugin present.
EXPORT OfxPlugin * OfxGetPlugin(int nth)
OfxPlugin * OfxGetPlugin(int nth)
{
if(nth == 0)
return &effectPluginStruct;
Expand Down
12 changes: 2 additions & 10 deletions Examples/Basic/basic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

template <class T> inline T Maximum(T a, T b) {return a > b ? a : b;}
template <class T> inline T Minimum(T a, T b) {return a < b ? a : b;}

Expand Down Expand Up @@ -1014,15 +1006,15 @@ static OfxPlugin basicPlugin =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth == 0)
return &basicPlugin;
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 1;
Expand Down
12 changes: 2 additions & 10 deletions Examples/ChoiceParams/choiceparams.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

// pointers64 to various bits of the host
OfxHost *gHost;
OfxImageEffectSuiteV1 *gEffectHost = 0;
Expand Down Expand Up @@ -760,15 +752,15 @@ static OfxPlugin basicPlugin =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth == 0)
return &basicPlugin;
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 1;
Expand Down
16 changes: 4 additions & 12 deletions Examples/ColourSpace/colourspace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

enum class ColourManagementStyle
{
None, Basic, Core, Full, OCIO
Expand Down Expand Up @@ -1104,23 +1096,23 @@ static OfxPlugin colourspacePlugin[] =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth < 3)
return &colourspacePlugin[nth];
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 3;
}

// Called first after loading. This is optional for plugins.
EXPORT OfxStatus
OfxSetHost()
OfxStatus
OfxSetHost(const OfxHost *)
{
return kOfxStatOK;
}
Expand Down
12 changes: 2 additions & 10 deletions Examples/Custom/custom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

#define kPointParam "point"
#define kDataParam "data"
#define kBigDataParam "big_data"
Expand Down Expand Up @@ -782,15 +774,15 @@ static OfxPlugin basicPlugin =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth == 0)
return &basicPlugin;
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 1;
Expand Down
12 changes: 2 additions & 10 deletions Examples/DepthConverter/depthConverter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

// Message id for the message posted when we don't have enough bits
#define kMessageNotEnoughBits "MessageIDNotEnoughBits"

Expand Down Expand Up @@ -607,15 +599,15 @@ static OfxPlugin basicPlugin =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth == 0)
return &basicPlugin;
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 1;
Expand Down
12 changes: 2 additions & 10 deletions Examples/DrawSuite/drawsuite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@

#include "../include/ofxUtilities.H" // example support utils

#if defined __APPLE__ || defined __linux__ || defined __FreeBSD__
# define EXPORT __attribute__((visibility("default")))
#elif defined _WIN32
# define EXPORT OfxExport
#else
# error Not building on your operating system quite yet
#endif

#define kPointParam "point"

// pointers to various bits of the host
Expand Down Expand Up @@ -448,15 +440,15 @@ static OfxPlugin basicPlugin =
};

// the two mandated functions
EXPORT OfxPlugin *
OfxPlugin *
OfxGetPlugin(int nth)
{
if(nth == 0)
return &basicPlugin;
return 0;
}

EXPORT int
int
OfxGetNumberOfPlugins(void)
{
return 1;
Expand Down
Loading
Loading