Conversation
kOfxParamPropDefaultCoordinateSystem describes the coordinate system of
a spatial double parameter's default, but the @propset blocks listed it
only under the ParamsNormalizedSpatial grouping, so the generated
accessor classes for the double parameter sets had no setter for it and
a plugin defining a spatial Double2D had to write the property by name.
It is now listed on ParamsDouble1D and ParamsDouble2D3D as well.
kOfxImageEffectInstancePropSequentialRender is documented as set by the
plugin ("for a plugin, indicates that it needs to be sequentially
rendered") and the Support library sets it in Describe, but the metadata
listed it only on the host and instance sets. It is now on the effect
descriptor too.
Regenerated headers and property reference included.
Assisted-by: Claude Code / Claude Fable 5.1
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Gary Oberbrunner <garyo@darkstarsystems.com>
Contributor
Author
|
Closing, superseded by #279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
@propsetlistings were incomplete, found by a metadata-driven host and plugin that generate their accessors from them:kOfxParamPropDefaultCoordinateSystemis documented for any spatial double parameter, but it was listed only under theParamsNormalizedSpatialgrouping. The generated accessor classes forParamsDouble1DandParamsDouble2D3Dtherefore had no setter for it, and a plugin defining a spatialDouble2Dhad to write the property by name. It is now listed on both double sets as well.kOfxImageEffectInstancePropSequentialRenderis documented as written by the plugin ("for a plugin, indicates that it needs to be sequentially rendered") and the Support library sets it on the descriptor indescribe, but the metadata listed it only on the host and instance sets. It is now onEffectDescriptortoo.No
#definechanges; regeneratedopenfx-cppheaders and the property reference are included.Test plan
uv run scripts/gen-props.pyandgen-props-doc.pyreproduce the committed filessetDefaultCoordinateSystemon the two double sets andsetSequentialRenderon the descriptorAssisted-by: Claude Code / Claude Fable 5.1
🤖 Generated with Claude Code