Add metadata for OpenGL texture handle - #276
Merged
garyo merged 2 commits intoSep 24, 2026
Merged
Conversation
Signed-off-by: umajho <umajho@proton.me>
…e handle Signed-off-by: umajho <umajho@proton.me>
umajho
force-pushed
the
opengl-texture-handle-metadata
branch
from
September 23, 2026 17:45
4dd5c96 to
3d0fc61
Compare
Contributor
Author
|
The two failing checks failed at |
Contributor
|
Nice work, thank you! I'll look into those test failures, you're right, nothing to do with you. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I added the metadata for the OpenGL texture handle returned by
OfxImageEffectOpenGLRenderSuiteV1::clipLoadTexturefollowing the instructions here.I chose
OpenGLTextureas the property set name to make its purpose clearer. However, If you thinkTexturewould be a better name, I can change it back.