Skip to content

[sanalyzer] cuVein code relocation#3

Open
FlagZhao wants to merge 7 commits intoAccelProf:cuVein_devfrom
FlagZhao:cuVein
Open

[sanalyzer] cuVein code relocation#3
FlagZhao wants to merge 7 commits intoAccelProf:cuVein_devfrom
FlagZhao:cuVein

Conversation

@FlagZhao
Copy link
Copy Markdown

No description provided.

@Lin-Mao Lin-Mao self-requested a review April 22, 2026 20:09
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please user sudmodule if possible. We may need to update the path to third_party/parallel-hashmap/parallel_hashmap in the compilation
https://github.com/greg7mdp/parallel-hashmap

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better codebase maintenance, we may need to move it to AccelProf/third_party like other libraries

Comment on lines +60 to +62
std::sort(sorted_heatmap_data.begin(), sorted_heatmap_data.end(), [](const std::pair<uint64_t, std::array<uint32_t, 18>>& a, const std::pair<uint64_t, std::array<uint32_t, 18>>& b) {
return a.first < b.first;
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::sort(sorted_heatmap_data.begin(), sorted_heatmap_data.end(), [](const std::pair<uint64_t, std::array<uint32_t, 18>>& a, const std::pair<uint64_t, std::array<uint32_t, 18>>& b) {
return a.first < b.first;
});
std::sort(
sorted_heatmap_data.begin(),
sorted_heatmap_data.end(),
[](const std::pair<uint64_t, std::array<uint32_t, 18>>& a, const std::pair<uint64_t, std::array<uint32_t, 18>>& b)
{
return a.first < b.first;
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants