Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository to use the AccessCodeLib/msaccess-vcs-build GitHub Action, normalizes VB module file encoding (inserting a BOM) across source files, corrects German umlaut encoding in many comments and error messages, and introduces AccUnit test factory modules for unit testing.
- Switches build workflows to the
msaccess-vcs-buildaction with thesourcedirectory - Inserts BOM markers in class/module files and fixes umlaut encoding (e.g., “für”)
- Adds AccUnit test class factory (
AccUnit_TestClassFactory.bas) and loader factory (AccUnit_Factory.bas)
Reviewed Changes
Copilot reviewed 82 out of 82 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/build-release-zip-file.yml | Uses source as source-dir, removes old vcs-url |
| .github/workflows/build-accdb.yml | Adds self-hosted Windows/Office build workflow |
| source/modules/ApplicationHandler_AppFile.cls | Inserts BOM, corrects umlauts in VB_Description and comments |
| source/modules/ApplicationHandler.cls | Inserts BOM, corrects umlauts in comments |
| source/modules/AccUnit_TestClassFactory.bas | New AccUnit test class factory function |
| source/modules/AccUnit_Factory.bas | New AccUnit loader factory and properties |
| source/modules/ACLibFileManager.cls | Inserts BOM, corrects umlauts in error messages |
| source/modules/ACLibConfiguration.cls | Inserts BOM, corrects umlauts in comments (“über”) |
| RepPath = PrivateRepositoryRootDirectory | ||
| If Len(RepPath) = 0 Then | ||
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert f�r privates Root-Verzeichnise fehlt (PrivateRepositoryRootDirectory = '')." | ||
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für privates Root-Verzeichnise fehlt (PrivateRepositoryRootDirectory = '')." |
There was a problem hiding this comment.
Typo in German: 'Verzeichnise' should be 'Verzeichnis'.
Suggested change
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für privates Root-Verzeichnise fehlt (PrivateRepositoryRootDirectory = '')." | |
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für privates Root-Verzeichnis fehlt (PrivateRepositoryRootDirectory = '')." |
|
|
||
| If Len(RepPath) = 0 Then | ||
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert f�r lokales Root-Verzeichnise fehlt (LocalRepositoryRootDirectory = '')." | ||
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für lokales Root-Verzeichnise fehlt (LocalRepositoryRootDirectory = '')." |
There was a problem hiding this comment.
Typo in German: 'Verzeichnise' should be 'Verzeichnis'.
Suggested change
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für lokales Root-Verzeichnise fehlt (LocalRepositoryRootDirectory = '')." | |
| Err.Raise vbObjectError, "getRepositoryFullPath", "Wert für lokales Root-Verzeichnis fehlt (LocalRepositoryRootDirectory = '')." |
|
|
||
| '--------------------------------------------------------------------------------------- | ||
| ' Erg�nzungen f�r Ereiterung: ACLibConfiguration | ||
| ' Ergänzungen für Ereiterung: ACLibConfiguration |
There was a problem hiding this comment.
Typo in German: 'Ereiterung' should be 'Erweiterung'.
Suggested change
| ' Ergänzungen für Ereiterung: ACLibConfiguration | |
| ' Ergänzungen für Erweiterung: ACLibConfiguration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.