View+endEditingOnTap #152
View+endEditingOnTap #152
Conversation
| @@ -0,0 +1,20 @@ | |||
| import SwiftUI | |||
|
|
|||
| @available(iOS 13.0, *) | |||
There was a problem hiding this comment.
The availability should be fixed for other platforms, probably check other extensions that are SwiftUI specific. That should fix the CI build.
There was a problem hiding this comment.
I would say, that having #if canImport(UIKit) && !os(watchOS) and then limit availability only to iOS feels weird, doesn't it? This would work on macOS, wouldn't it? Not sure about tvOS, but I would say so.
olejnjak
left a comment
olejnjak
left a comment
There was a problem hiding this comment.
The availability should be fixed for other platforms, probably check other extensions that are SwiftUI specific. That should fix the CI build.
|
@LukasHromadnik 🙏 🙄 |
LukasHromadnik
force-pushed
the
swiftui/endEditingOnTap
branch
from
9c26c2c to
4075901
Compare
| @@ -0,0 +1,20 @@ | |||
| import SwiftUI | |||
|
|
|||
| @available(iOS 13.0, *) | |||
There was a problem hiding this comment.
I would say, that having #if canImport(UIKit) && !os(watchOS) and then limit availability only to iOS feels weird, doesn't it? This would work on macOS, wouldn't it? Not sure about tvOS, but I would say so.
| @available(iOS 13.0, *) | ||
| public extension View { | ||
|
|
||
| @available(iOSApplicationExtension, unavailable) |
There was a problem hiding this comment.
We can move this availability clause to the extension itself so it is at one place.
3 participants
Add
endEditingOnTapmodifier that is used across our SwiftUI projectsChecklist