fix: resolve all pre-existing compliance violations#26
Merged
josealekhine merged 1 commit intoActiveMemory:mainfrom Mar 6, 2026
Merged
fix: resolve all pre-existing compliance violations#26josealekhine merged 1 commit intoActiveMemory:mainfrom
josealekhine merged 1 commit intoActiveMemory:mainfrom
Conversation
bilersan
force-pushed
the
fix/compliance-violations
branch
from
bf92fef to
daf908e
Compare
- Add compliance test suite (internal/compliance/compliance_test.go)
20 tests covering SPDX headers, doc.go presence, literal strings,
cmd.Printf usage, gofmt, go vet, golangci-lint, and more.
- Fix SPDX license headers (11 files)
Truncated 'Apache-2.' → 'Apache-2.0' and add missing headers.
- Add doc.go files (19 packages)
assets, bootstrap, cli/{decision,doctor,notify,pause,remind,resume,task},
context, crypto, drift, eventlog, index, journal/state, notify, rc,
recall/parser, task.
- Replace literal strings with config constants
'\n' → config.NewlineLF (31 files)
'.md' → config.ExtMarkdown (13 files)
- Replace cmd.Printf/PrintErrf with Println/Print + fmt.Sprintf (45 files)
Preserves original newline behavior: Printf with trailing \\n uses
Println, Printf without \\n uses Print.
- Fix golangci-lint staticcheck S1025 (validate.go)
- Update TestRequiredContextFilesInTemplate path to match current
internal/assets/context/ structure.
All 20 compliance tests pass. No new test regressions introduced.
Closes ActiveMemory#25
Signed-off-by: ersan bilik <ersanbilik@gmail.com>
bilersan
force-pushed
the
fix/compliance-violations
branch
from
daf908e to
39126cc
Compare
Member
|
Further changes might be done BUT
LGTM 🌮 I can use Daniel (my agent) to do a deeper sweep afterall :). Thanks for your contribution @bilersan 🙏 . |
Member
|
For context here were my initial findings:
All of them can be fixed by an agent sweep. Even better, all of them can be asked for an agent to "write a linter" for future sweeps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
Summary
Fix all 5 categories of pre-existing compliance violations caught by
internal/compliance/compliance_test.go. Total: 46 files changed across the codebase.Changes
1. SPDX License Headers (11 files)
Apache-2.→Apache-2.0in 6 config files2. Missing
doc.goFiles (11 packages)doc.gofor: bootstrap, cli/decision, cli/task, context, crypto, drift, index, rc, recall/parser, task, tpl3. Literal
"\n"→config.NewlineLF(9 files)4. Literal
".md"→config.ExtMarkdown(4 files)5.
cmd.Printf/cmd.PrintErrf→cmd.Println/cmd.PrintErrln(20 files)Verification
go build ./cmd/ctx)go vet ./...passes