Skip to content

fix: refactored flood to better behavior#105

Open
ErikBjare wants to merge 1 commit intomasterfrom
dev/better-flood
Open

fix: refactored flood to better behavior#105
ErikBjare wants to merge 1 commit intomasterfrom
dev/better-flood

Conversation

@ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Sep 2, 2021

I've had this in my working tree for a while. Should be improved behavior better aligned with how aw-server-rust works. Will hopefully fix ActivityWatch/activitywatch#626.

(Needs thorough review, long time since I wrote this, and can't remember what I've done)

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

❌ Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (efd1325) to head (0b47c01).
⚠️ Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
aw_transform/flood.py 69.56% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   90.78%   90.16%   -0.63%     
==========================================
  Files          34       34              
  Lines        1660     1687      +27     
  Branches      257      262       +5     
==========================================
+ Hits         1507     1521      +14     
- Misses        118      131      +13     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErikBjare
Copy link
Member Author

Since this is based on the aw-server-rust implementation, I just want to note that it might not be without issues either: ActivityWatch/activitywatch#602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More time reported than actual usage

1 participant