Repository navigation
feat: 10-minute stats during the v0.14.0 launch; exclude updater assets from totals #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e07e592
f67fa28
07c0318
2d9adda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| timestamp,channel,url,note | ||
| 2026-10-06T13:38:00+00:00,github,https://github.com/ActivityWatch/activitywatch/releases/tag/v0.14.0,v0.14.0 published | ||
| 2026-10-06T17:00:00+00:00,discord,,v0.14.0 announcement in #announcements (approximate time) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import collect_stats | ||
| from collect_stats import is_updater_asset, platform | ||
|
|
||
|
|
||
| def test_updater_assets_are_excluded_from_downloads(): | ||
| assert is_updater_asset("latest.json") | ||
| assert is_updater_asset("activitywatch-tauri-0.14.0-darwin-aarch64.app.tar.gz") | ||
| assert is_updater_asset("activitywatch-tauri-0.14.0-linux-aarch64.AppImage.sig") | ||
| assert not is_updater_asset("activitywatch-v0.14.0-windows-x86_64-setup.exe") | ||
| assert not is_updater_asset("activitywatch-tauri-0.14.0-linux-x86_64.AppImage") | ||
| assert not is_updater_asset("activitywatch-v0.14.0-macos-arm64.dmg") | ||
|
Comment on lines
+5
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Add a test that replaces Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 07c0318: test_downloads_total_excludes_updater_assets checks the total (320). |
||
|
|
||
|
|
||
| def test_platform(): | ||
| assert platform("activitywatch-tauri-0.14.0-darwin-aarch64.app.tar.gz") == "macos" | ||
| assert platform("latest.json") == "unknown" | ||
|
|
||
|
|
||
| def test_downloads_total_excludes_updater_assets(monkeypatch): | ||
| assets = [ | ||
| { | ||
| "tag": "v0.14.0", | ||
| "asset": "activitywatch-v0.14.0-windows-x86_64-setup.exe", | ||
| "platform": "windows", | ||
| "downloads": 300, | ||
| }, | ||
| { | ||
| "tag": "v0.14.0", | ||
| "asset": "activitywatch-tauri-0.14.0-linux-x86_64.AppImage", | ||
| "platform": "linux", | ||
| "downloads": 20, | ||
| }, | ||
| { | ||
| "tag": "v0.14.0", | ||
| "asset": "latest.json", | ||
| "platform": "unknown", | ||
| "downloads": 51, | ||
| }, | ||
| { | ||
| "tag": "v0.14.0", | ||
| "asset": "activitywatch-tauri-0.14.0-darwin-aarch64.app.tar.gz", | ||
| "platform": "macos", | ||
| "downloads": 6, | ||
| }, | ||
| { | ||
| "tag": "v0.14.0", | ||
| "asset": "activitywatch-tauri-0.14.0-darwin-aarch64.app.tar.gz.sig", | ||
| "platform": "macos", | ||
| "downloads": 3, | ||
| }, | ||
| ] | ||
| monkeypatch.setattr(collect_stats, "downloads_by_asset", lambda: assets) | ||
| assert collect_stats.downloads() == 320 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
collect-statsgroup covers only stats runs, not the Play Console workflow. With stats now pushing every ten minutes, a stats commit can land while Play collects its daily data. Play then pushes from its older checkout without pulling, so its push is rejected and the collected Android data never reaches the repository.The new
git pull --rebaseprotects only the stats side. Give both workflows the same concurrency group, or make both writers pull and retry rejected pushes.Knowledge Base Used: Collection automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 07c0318 and the follow-up: both workflows push with rebase-and-retry.