Ports - Sopheary & Jessica by sophearychiv · Pull Request #16 · Ada-C11/slack-cli

sophearychiv · 2019-03-22T23:00:26Z

slack.rb

Congratulations! You're submitting your assignment!

You and your partner should collaborate on the answers to these questions.

Comprehension Questions

Question	Answer
How did you go about exploring the Slack API? Did you learn anything that would be useful for your next project involving an API?	We explored Slack API during the lectures while following along with the instructor during live code sessions. We also used Postman to experiment with the query parameters. Also, we read the documentation on Slack's web pages. We learned using VCR to test the APIs, which is different from the regular tests.
Give a short summary of the request/response cycle. Where does your program fit into that scheme?	request/response cycle is the process of requesting the data from the client to the server. After receiving the requesting, the server processes the request and responds to the client. Our program requests the data from Slack APIs to make the lists of users and channels. Slack, then, process our requests and respond to our program with the info of the users and the channels. In regards to sending the message to the users or channels, our program sends POST requests to Slack which processes the requests and responds the messages back to the program.
How does your program check for and handle errors when using the Slack API?	Our program uses custom errors to check and handle the errors by checking if the code status is not 200 OK or the response is not "ok".
Did you need to make any changes to the design work we did in class? If so, what were they?	Yes, we did. We created parameters for most of the methods in workspace, so that the main method could be responsible for only printing the responses from user input. We also didn't implement the details method like the instructor's design.
Did you use any of the inheritance idioms we've talked about in class? How?	We used an abstract class (Recipient) with template method self.list, for example.
How does VCR aid in testing a program that uses an API?	It allows us to make a single call to the API and store the response so that when testing we don't have to continue to access the API and can instead access internal data. This makes testing faster and cheaper.

… user and channel classes

…thod in main

Hopefully this doesn't break things....

…when testing

…sed if invalid query is sent to API

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

CheezItMan · 2019-03-31T22:32:39Z

slack.rb

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene (no slack tokens)	Good number of commits and good commit messages, no api key in git!
Comprehension questions	Check
Functionality
List users/channels	Check
Select user/channel	Check
Show details	Check
Send message	Check
Program runs without crashing	Check
Implementation
API errors are handled appropriately	Check
Inheritance model matches in-class activity	Check
Inheritance idioms (abstract class, template methods, polymorphism) used appropriately	Check, really nice work here
Methods are used to break work down into simpler tasks	Check, nice work drying some of the methods like selecting a user/channel.
Class and instance methods are used appropriately	Check
Overall	Really well done, you definitely hit the learning goals here. Nice work. Look at my comments and let me know if you have questions.

CheezItMan · 2019-03-31T22:23:57Z

lib/sample.rb

@@ -0,0 +1,19 @@
+require "dotenv"


This shouldn't be checked into git

CheezItMan · 2019-03-31T22:24:56Z

lib/user.rb

+      @status_text = status_text
+      @status_emoji = status_emoji
+    end
+


No details method?

CheezItMan · 2019-03-31T22:25:12Z

lib/channel.rb

+      @topic = topic
+      @member_count = member_count
+    end
+


No details?

CheezItMan · 2019-03-31T22:26:03Z

lib/workspace.rb

+      selected.send_message(message)
+    end
+
+    def tp_details_options


Instead of doing this in the Controller/Workspace, you could instead just return selected.details if you'd implemented that method in the User or Channel classes.

CheezItMan · 2019-03-31T22:27:09Z

lib/workspace.rb

+    private
+
+    def select(input, recipients)
+      recipients.each do |recipient|


find would be a great option here.

CheezItMan · 2019-03-31T22:28:36Z

specs/recipient_spec.rb

@@ -0,0 +1,72 @@
+require_relative "test_helper"
+# THIS IS MY COMMENT - Jessica


And what a comment it is 😀

CheezItMan · 2019-03-31T22:29:11Z

specs/recipient_spec.rb

+  describe "send message" do
+    it "sends a valid message" do
+      VCR.use_cassette("slack_message") do
+        users = Slack::User.list


This seems to be testing User rather than recipient.

CheezItMan · 2019-03-31T22:29:33Z

specs/recipient_spec.rb

+      end
+    end
+
+    it "raises an error if api sends back not okay" do


You should test this with both an invalid token and again with an empty message.

CheezItMan · 2019-03-31T22:31:20Z

lib/workspace.rb

+    end
+
+    def select_user(input)
+      select(input, users)


Really good work drying this up!

CheezItMan · 2019-03-31T22:31:44Z

specs/workspace_spec.rb

+  end
+
+  describe "send_message" do
+    it "sends a valid message" do


You should also test it with invalid messages.

jessicacaley and others added 30 commits March 18, 2019 22:20

Verify API connection

c1721fb

Moved code that tests for API connection from slack.rb to sample.rb

3f6355f

Change single quotes to double quotes (autoformat)

a2888cb

Change puts to awesome print

4d215ed

Move sample.rb to lib folder

2ea5cbb

Set up frame work and created self.list (unfinished)

7721094

Set up frame work and created self.list (unfinished)

2124ce8

Created framework and test for instantiation

741eb1a

Created framework and test for instantiation

93f9d43

Add require_relatives

85e1e42

Add require_relatives and started messing with VCR (not finished)

3bfc600

started experimenting testing api

974dea1

Set up VCR - all current tests passing

6b16489

Fix cassettes structure and functionality

38bb11a

Optimize self.get method and added some tests

c6b4728

added tests Recipient and User

984651a

Create CLI interface to list users, list channels, and quit (wave 1)

a08df6e

Modify list users and list channels to pull from workspace instead of…

a597ac3

… user and channel classes

Implement select user, select channel, and details user options

64db0f3

added tests for select_channel and select_user

6095d8c

changed the tests for the select methods and took out the validate me…

0109340

…thod in main

Add test for show_details (99% code coverage)

3c94fdd

Add tests for show details

04f47fe

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

d407c29

Hopefully this doesn't break things....

Add test keyword argument to show_details so printing doens't happen …

0cfd52f

…when testing

Modify token to keyword argument so test can check if argument is rai…

25c2314

…sed if invalid query is sent to API

Delete unused variable assignments

d35621b

Implement send messaage

c1a156a

added a test to send.message

0854acd

Add tp option methods to workspace

e64b72b

Sopheary Chiv and others added 17 commits March 22, 2019 14:42

testing git conflicts

679d950

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

84b6ebc

Add comment to test git merge

222abdb

Testing git merges...

622ced4

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

changed slack_id to 40

0177af8

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

dabee14

Change slack_id in recipient spec to test git conflicts

974f1a5

Resolve changes

bff90f5

Resolve errors coming from testing conflicts

f6287cd

Add logic to print errors to user and modified tests

24c2ae3

added tests for send_message in workspace

831aad7

Add tests for tp options

48487a2

Merged changes

0e43c94

Modify test for sending message

3326d73

fixed send_message test

3188b22

Add SimpleCov filter

31a5009

Merge branch 'master' of https://github.com/sophearychiv/slack-cli

23226fa

CheezItMan reviewed Mar 31, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Sopheary & Jessica#16

Ports - Sopheary & Jessica#16
sophearychiv wants to merge 47 commits intoAda-C11:masterfrom
sophearychiv:master

sophearychiv commented Mar 22, 2019 •

edited

Loading

Uh oh!

CheezItMan commented Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

CheezItMan Mar 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,72 @@
		require_relative "test_helper"
		# THIS IS MY COMMENT - Jessica

Conversation

sophearychiv commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

slack.rb

Comprehension Questions

Uh oh!

CheezItMan commented Mar 31, 2019

slack.rb

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sophearychiv commented Mar 22, 2019 •

edited

Loading