Open
Conversation
CheezItMan
reviewed
Sep 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
The first method works well, nice work. See my note on the time complexity. For the other I left a note about where I think you started to get off track.
Overall, not bad!
| @@ -1,13 +1,45 @@ | |||
| require "pry" | |||
| # Time Complexity: ? O(n) where n corresponds with the length of input array | |||
There was a problem hiding this comment.
Since delete_at shifts all subsequent elements over one index, the time complexity of delete_at is O(n) and so your method is O(n2).
|
|
||
| strings.each_with_index do |string, i| | ||
|
|
||
| return a if string[i][j] != collection_of_letters |
There was a problem hiding this comment.
I think you mean string[j] != collection_of_letters[j] here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.