Open
Conversation
CheezItMan
reviewed
Feb 1, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
I like the consistent naming of the helper methods. Thanks for getting this in Laurel. Take a look at my feedback and let me know if you have questions.
binary_search_tree/tree.py
Outdated
Comment on lines
16
to
18
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add(self, key, value = None): |
There was a problem hiding this comment.
👍 However the time complexity is O(n) for an unbalanced tree and O(log n) for a balanced tree.
Also the space complexity is the same due to the call stack (recursion).
Comment on lines
+34
to
36
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def find(self, key): |
Comment on lines
+49
to
51
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder(self): |
Comment on lines
+72
to
74
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder(self): |
Comment on lines
+118
to
120
| # Time Complexity: O(n) | ||
| # Space Complexity: O(log n) | ||
| def height(self): |
There was a problem hiding this comment.
👍 Space complexity is right if the tree is balanced O(n) otherwise.
binary_search_tree/tree.py
Outdated
Comment on lines
136
to
138
| # # Time Complexity: O(n) | ||
| # # Space Complexity: O(n) | ||
| def bfs(self): |
There was a problem hiding this comment.
👍 However since you're using an array as a queue the queue.pop(0) is an O(n) operation by itself making your BFS solution O(n^2). You can reduce this by using a deque or a linked list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.