Conversation
Its sources may be rooted at different paths, so at the root their focus bytes differ and the debug assert failed; sibling steps then tried to move the root. Report None at the root.
The branch meant to bring the second source down to the first one's depth descended the first source again, leaving them at different depths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OverlayZipper focus_byte at the root
Its sources may be rooted at different paths, so at the root their focus
bytes differ and the debug assert failed; sibling steps then tried to
move the root. Report None at the root.
Fix OverlayZipper::descend_to_val when the second source stops first
The branch meant to bring the second source down to the first one's
depth descended the first source again, leaving them at different depths.