Fix ProductZipper sibling step failing at a factor root - #149
Merged
luketpeterson merged 1 commit intoOct 2, 2026
Merged
luketpeterson merged 1 commit into
luketpeterson merged 1 commit into
Conversation
Collaborator
|
This needs a closer look. That deregularize-regularize loop isn't free. I'm worried we're using a sledgehammer on a flea. But I don't have time to look closer until later. |
Collaborator
|
NM the earlier comment. I was in a hurry and didn't notice this already was happening inside the factor-transition branch. Good fix. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enroll_next_factorfabricates a node stack frame that the core zipper's sibling step can't reason about, and thederegularize/regularizereverses that.