CI validation: incorrect Strength-to-Life calculation (do not merge) - #3
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intentional test of the build comparison pipeline in this fork. Please don't merge it.
I changed the Strength-to-Life calculation from one Life per two Strength to one Life per Strength. This should give affected builds too much Life while still letting PoB finish its calculations normally. There is no forced error and no change to the test scripts.
The GitHub run finished in 9 minutes 8 seconds. It downloaded the actual pob.codes collection and calculated all 500 API builds plus the five existing fixtures on both revisions.
The uploaded report shows increased player Life for 346 API builds and all five fixtures. For example, Dual Savior went from 92 Life to 118. I also checked that fixture locally: it has 52 Strength, so the extra 26 Life is exactly what this mistake should produce. One API build, beginning
0141a237, went from 4,551 Life to 4,809.The check is green because the current workflow reports numerical differences for review; it only fails the job when calculation or comparison cannot complete. The report caught the incorrect values as intended.
To inspect it, open the run above and download the
build-diff-outputartifact. Search the file forOutput Diff for Dual Savior.xml.build, thenLife Mismatch. In the report,head Outputis the changed PR anddev Outputis the base. The fork's test artifacts expire after one day; the same output is also in the Calculate builds job log.