CI validation: fail on calculated-stat differences (do not merge) - #4
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intentional test in this fork. Please don't merge it.
I changed one line so Strength grants twice as much Life as it should. PoB should still calculate normally. There is no forced error and this PR doesn't change the test scripts.
The base branch now shows a short build comparison summary directly on the GitHub run page, and calculated-stat differences make the check fail after it finishes comparing all builds. The full XML, timing and stat report is still available. A completed baseline can still be cached when the comparison finds differences.
The GitHub run completed all 505 comparisons against the actual pob.codes collection and failed on the stat differences, as intended. It calculated all 500 API builds plus the five fixtures on both revisions without a calculation error.
The summary reports 414 builds with stat differences, including 351 with changed Life. For example, the API build beginning
0141a23792a9went from 4,551 to 4,809 Life. Dual Savior went from 92 to 118. These are real calculation changes from the one-line mistake.To see the short report, sign in to GitHub, open the run above, and look for Build comparison summary. It contains the counts and 25 stat rows with before/after examples. The summary is about 2.6 KB; the full report remains in
build-diff-outputfor deeper investigation. The completed baseline cache and full report both saved successfully despite the red check.Local checks also passed: 590 unit tests, workflow validation, and a six-build comparison with unchanged calculation code. Applying the intentional formula mistake locally completed all six comparisons and failed with five builds showing stat differences.