Align PHP Randflake parity with original implementation#1
Merged
Conversation
Use the upstream official test vectors to verify encrypted IDs, base32hex strings, and inspect output against the Go implementation. Switch SPARX-64 packing to little-endian and replace RFC4648 byte Base32Hex with Randflake's mathematical base32hex conversion.
- Add constants section header. - Add comment to B32HEX_CHARS constant. - Add `@throws` documentation to `decodeBase32HexToNumericString()`.
Adambean
reviewed
May 27, 2026
Owner
Adambean
left a comment
Adambean
left a comment
There was a problem hiding this comment.
Thank you kindly for reviewing this library. Looks like I was using big endian numbers instead of little endian, my fault for using Windows calculator for my bin/dec/hex conversions. Also very cool to reduce that single dependency.
Adambean
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align PHP Randflake parity with original implementation
Summary
Align the PHP implementation with the original Go/Python/TypeScript Randflake behavior.
Changes
inspect output.
Verification
phpunitphpstan analysephp-cs-fixer --dry-runcomposer validate --strict