Remove pkg resources #272
Merged
Remove pkg resources #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @vovw , thanks! Could you select only this commit 
on this PR? |
- Replace pkg_resources.parse_version() with packaging.version.parse() - Replace pkg_resources.get_distribution() with importlib.metadata.distribution() - Update imports in cebra/integrations/sklearn/cebra.py, cebra/helper.py, tests/test_sklearn.py, tests/test_plot.py - Fixes deprecation warning: pkg_resources is deprecated as an API and slated for removal as early as 2025-11-30 Resolves AdaptiveMotorControlLab#271
vovw
force-pushed
the
remove-pkg-resources
branch
from
849f1a8 to
ce9d817
Compare
Contributor
Author
|
should be fixed |
MMathisLab
approved these changes
Sep 24, 2025
stes
approved these changes
Sep 24, 2025
Member
stes
left a comment
stes
left a comment
There was a problem hiding this comment.
lgtm, i would propose to ignore the windows test
MMathisLab
merged commit 6e0e2f4
into
AdaptiveMotorControlLab:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #271