feat: Shot spillover; Speed force; scr_shoot refactor#1309
Draft
EttyKitty wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
2 issues found across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
f52e991 to
48c0607
Compare
48c0607 to
19170ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds shot spillover across enemy ranks and formations and introduces the Speed Force sweep attack, producing a single consolidated volley. Refactors
scr_shootinto modular helpers and splits enemy/player flows for clearer damage, AP, and cleanup.New Features
scr_shoot_spread(bypasses range/targeting), allocates shots by rank size, and reports one volley; auto-added tobikestacks with an optional ranged variant.find_next_alive_rank,get_next_enemy_formation,combat_apply_rank_damage,combat_rank_armour, and formation cleanup;scr_cleannow usescombat_rank_armour.Bug Fixes
Written for commit 19170ee. Summary will update on new commits.