feat: Planet buttons; CombatDebugger; Chores#1314
Merged
Merged
Conversation
EttyKitty
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 29 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
EttyKitty
changed the title
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reply with Previous Review Summaries (6 snapshots, latest commit 67f6ac5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 67f6ac5)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reply with Previous review (commit 0250487)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous review (commit 59bda1e)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous review (commit e68792e)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit d7b48b2)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous review (commit d236bad)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (8 files)
Reviewed by step-3.7-flash-20260528 · Input: 543.2K · Output: 79K · Cached: 7.4M |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Continue during looping was causing trailing commas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a structured combat debugger across the combat flow and writes a detailed log at battle end. Refactors planet action UI to dynamic
buttons[]/shutters[]with clearer rules, plus tighter faction/ownership logic and alerts.New Features
CombatDebugger: in‑memory buffer with categories (SYSTEM, TARGETING, SHOOTING, DAMAGE, CLEANUP); flushes tocombat_debug_*.logwith battle info; cleaned up on destroy; includesresolve_labelfor readable unit names.scr_cleandamage, array compression/column destruction, and turn start markers; flush on combat end.Refactors & Fixes
button1..5withbuttons[]/shutters[]; shutters auto-scale and block click-through (obj_p_fleet/obj_en_fleetandscr_void_click); rules usePlanetData.has_enemy_force()/has_any_force(); handles Space Hulk (“Raid” + “Bombard”) and clean add/remove of “+Recruiting”.format_time/format_codeblockto string utils; fixedarrays_to_string_with_countscomma bug; marine location truncation now preserves planet numerals; bomb selector shows full ship names and removesstring_deletewarning.eFACTIONenum made explicit with_COUNTand applied in enemy AI and star ownership;xenos_and_heretics()now excludes Ecclesiarchy; corrected Ork/Tyranid/Chaos/Tau reset paths, Daemon planets forced to Chaos; improved “Cleansed” alert conditions and messaging.Written for commit a992c24. Summary will update on new commits.