fix(shell): preserve final summaries beyond the output cap - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Verbose shell commands dropped their real final summary after 64 MiB. Shared console shell commands also retained only their first 8,000 characters. Both paths now retain actual head and final output with fixed memory, while stdout/stderr continue draining and streaming.
Closes #247.
What changed
/shell-resultsharing. Persistent callbacks continue beyond the retention budget.Verification
npm testexited 0. Complete bounded full-suite report: 2,930 tests; 2,919 passed; 11 skipped; 0 failed; 0 cancelled (143.0 seconds). The final verifier usednode --test --test-isolation=none --test-timeout=30000 --test-reporter=tap --test-reporter-destination=<report> "dist/test/**/*.test.js"to prove all tests finished.Acceptance mapping and reproduction evidence: docs/issue-247-validation.md.
Remote source tree exactly matches the local tested tree:
2ac4ecfbebd4a2a8aaca8b5bab7210bae56e2b95.Scope and risk
Execution authority and status prefixes remain unchanged. The payload buffers retain 7,920 bytes, reserving room within the 8,000-byte body budget for the elision notice; Unicode output may therefore be shorter than the old character-based cap. Omission counts describe decoded/normalized UTF-8 bytes. Live callbacks receive all decoded output and consumers remain responsible for their own retention. File/web/search character caps remain unchanged. Local verification is Linux; persistent Bash tests skip unsupported platforms.