Repository navigation
fix: secure agent setup origins and key replacement - #46
Merged
Merged
Conversation
sonpiaz
changed the title
sonpiaz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent setup now refuses to send a signed-in user JWT outside
https://api.affitor.com. Local development requiresAFFITOR_AGENT_DEV_API_ORIGINto match the exact loopback origin, including port. Rejected origins fail before HTTP or agent-file writes.When a selected saved key is active but its hint no longer matches, the preview explains replacement and revocation before consent. Approved setup saves new credentials first, then revokes only the previous selected ids. Mint or local-write failure preserves old keys and compensates newly minted keys. Failed old-key revocation preserves the installed replacement and reports the old ids for dashboard cleanup, without claiming rollback.
The README also documents interrupted-setup recovery and Windows ACL limits.
Validation: 344 workspace tests passed (25 recipes, 299 CLI, 20 MCP); six real-Windows-only smoke cases run in CI. Workspace build, TypeScript lint, and diff checks passed. Includes real built-CLI consent/dry-run, replacement/revocation failure, JWT-origin rejection, request ordering, and credential-output regressions.
Release: stacked on #45; CMS #553/#561 must be live and the manager must authorize release. No version bump or publish. Abrupt interruption can still leave unused credentials requiring dashboard cleanup; no crash recovery transaction or Windows ACL proof is claimed.