Skip to content

teams: a local launch writes no Close/Reopen note to the team's Traffic #1524

Description

@AbirAbbas

What happened

On a plain codeaf launch (no --host), closing a team and reopening it on the teams page writes no Close/Reopen note to that team's Traffic log. teamsUndoClose in internal/tui3/teamclose.go sends the person reopened the team, and close sends its equivalent, but on a local launch neither reaches the log. This was found on 2026-09-25 while fixing #1516's item 6.

It has the same cause as #1516's item 6. The local launch's teams seam (localDoors in cmd/codeaf/chatv3_local.go) was not handed the door that the engine road uses. Item 6 fixed History; the Traffic write for these notes is still missing.

Replication

Deterministic: a cmd/codeaf test that builds the plain-launch doors (localDoors), closes a team through the seam and reopens it, then reads teams.ReadTraffic for that team. Today no close/reopen entry is there. TestPlainLaunchReadsClosedTeamReportFromEngineProfile (#1516) is the pattern to copy.

By hand:

  1. Run codeaf.
  2. Press alt+2, make a team with a manager, and close it with Close.
  3. Reopen it with u.
  4. Look at the manager's Traffic column. It shows no close or reopen line.

The fix

A local launch writes the same Close/Reopen notes to Traffic as the engine road does.

Acceptance

  • e2e: on a plain launch, the manager's Traffic shows the close and the reopen lines after the steps above.
  • Unit: the localDoors seam test sees both entries in teams.ReadTraffic.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:chatThe v3 surface a person sits in front of (internal/tui3)bugSomething the code does that it should notsev:papercutA wording, a hint, a small wrongness that costs a moment

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions