tui3: an air row under the nav — proper spacing between the top header rows - #1509
Open
santoshkumarradha wants to merge 2 commits into
Open
santoshkumarradha wants to merge 2 commits into
santoshkumarradha wants to merge 2 commits into
Conversation
santoshkumarradha
marked this pull request as ready for review
September 25, 2026 15:58
Member
Author
Visual Proof: Live TUI on DGX Spark (SSH)Captured live from DGX Spark (
Test suite: drafted with CodeAF |
Member
Author
Live TUI Header Spacing on Spark (tmux)Here is the live capture of the TUI running in a tmux session ( Observed layout:
— |
Member
Author
Authentic Graphical Window Capture (tmux + live codeaf TUI)Updated Confirmed visual characteristics:
— |
Member
Author
|
@AbirAbbas this PR is ready for review. |
Port of the five-row head onto dev's conditional-strip architecture: the strip only draws while a conversation is in front, so the air row is the head's own. A place spends four rows (nav, air, rule, blank: placeHeadRows 3→4); a conversation five (the strip back in its place between the air row and the rule: chatHeadRows = placeHeadRows + 1, tabStripRow = 2). Design references and the live spark capture ride along under docs/design/.
santoshkumarradha
force-pushed
the
task/top-nav
branch
from
September 25, 2026 17:57
0e50321 to
55e4de1
Compare
Assisted-by: CodeAF (gemini-3.8-flash-high) Co-Authored-By: CodeAF <267109073+agentfield-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Live TUI on Spark (DGX)
Live terminal pane capture from DGX Spark over SSH running the branch build in tmux (3008×944). Demonstrates the 5-row header contract: Row 1 (top nav), Row 2 (blank air row), Row 3 (tab strip '+'), Row 4 (divider rule), Row 5 (margin blank row).
The change: proper spacing between the top header rows
The two top rows of the head — the nav row (the wordmark, the places, the machine's
pulse on the far end) and the chat strip — used to sit directly on top of each
other. This PR inserts one full blank row of air between them. The head is now
five rows on every page: nav → air → strip → rule → blank (placeHeadRows
4→5, tabStripRow 1→2), unchanged at every size on a place and on a
conversation alike, so walking between pages still moves nothing a person has found.
The air row is exactly the branch's own sanctioned path — placebodies.go already
said a fifth head row is "a change to this constant and to nothing else" — and
now it lands. The welcome screen's minimum-height reserve gives one row back to
the head, and the tests' frames grow one row to keep charging it.
Tests and review
go test ./internal/tui3/— green, all sizes from the head's invariants:the strip on row two under the air row; the head closes with a rule and a blank;
every place spends the same five rows.
go build ./...andgo vet ./internal/tui3/— clean.at every width/height in head_test.go and topnav_test.go; zero regressions.
comments and docs updated to the five-row vocabulary everywhere; the docs'
design references record the visual intent.
Design references
docs/design/spark-header-spacing.png— live Spark SSH terminal pane screenshot.docs/design/header-spacing-reference.png— canonical (grok).docs/design/header-spacing-ref-gpt-image.png— OpenAI rejected the model route(400 unknown model); the rendered fallback records the intent.
docs/design/header-spacing-ref-flux.png,docs/design/header-spacing-ref-imagen.png.Live Spark tmux Screenshot
—
Drafted with CodeAF · reviewed and owned by the author