senior-dev: plain folders start again, and shell model names resolve - #1530
Merged
Merged
Conversation
On dd0fcc6 (#1488 merged) a senior-dev run in a folder with no git crashed at bootstrap before its first model call: "read start-time ignore list: open .../ignored-at-start: no such file or directory". Folder preparation returned on the plain road (and the gitignored-subfolder road, which takes it too) before writing the start-time ignore list, while the shell and the chat both still handed its path to the child, which refuses an unreadable list. Preparation now writes an empty, readable list there first, so the run works in place and commits nothing again; a repository's list is written and honoured as before. Tests start the real child on the shell road and as the chat's run worker in a plain folder. Found by a real-model run of the merged build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
codeaf senior-dev --high z-ai/glm-5.3-flash failed after launch with 'models.dev: provider "z-ai" not found' because the value went to senior-dev as typed and its first segment was read as a provider; only openrouter/z-ai/... worked. The shell now resolves --high and --asked through the same model matcher and connected-service check the chat's proposals use, and hands the child the qualified id. A bare OpenRouter id, a service-prefixed id and a short crew word all work; a model no connected service can serve is refused before the child starts, naming /crew and codeaf connect. The manual says what --high accepts. Found by a real-model run of the merged build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
AbirAbbas
marked this pull request as ready for review
September 26, 2026 01:58
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1488. Two senior-dev defects a real-model run of the merged build (dev
dd0fcc654) found.What was wrong
codeaf senior-dev --dir <plain folder> …exited 2 at bootstrap withread start-time ignore list: open …/ignored-at-start: no such file or directory, and the chat road's run worker hit the same thing. Folder preparation returned on the plain road (and the gitignored-subfolder road) before writing the start-time ignore list, while both roads still handed its path to the child. This came from senior-dev: a coding agent built into codeaf takes a whole task, in the folder itself #1488's review fixes, after the plain-folder road had last been checked.--highneeded the service prefix on the shell road.--high z-ai/glm-5.3-flashfailed after launch withmodels.dev: provider "z-ai" not found; onlyopenrouter/z-ai/glm-5.3-flashworked.What changed
--highand--askedthrough the same model matcher and connected-service check the chat's proposals use, and hands the child the qualified id. A bare OpenRouter id, a service-prefixed id and a short crew word all work. A model no connected service can serve is refused before the child starts, naming/crewandcodeaf connect. The manual says what--highaccepts.How it was checked
dd0fcc654first.z-ai/glm-5.3-flash, about $0.002):mainunchanged and a clean tree. The commit carries the run's identity, no.pycfiles were committed, and the tests pass when rerun.make test-laws, the manual gates and the env-pin law all pass. The change entry is included.🤖 Generated with Claude Code