fix(session): skill suitability block isolation and regression tests (#1504) - #1532
Open
santoshkumarradha wants to merge 2 commits into
Open
santoshkumarradha wants to merge 2 commits into
santoshkumarradha wants to merge 2 commits into
Conversation
…skills (#1504) The skills block rides the copy the model reads; the record the surfaces draw keeps the person's own words, and the dim skills-carried line is the one visible channel. Adds the end-to-end regression test through the real chat door, and lands the full internal/session suite green: the lane-news test helper no longer hands an earlier test's held sighting to the first reader of the next, and the ignored-folder receipt test wants the canonical spelling the receipt actually prints.
santoshkumarradha
added
bug
…tore back The end-to-end test read brain.Messages straight after the turn's events closed, but the transcript reaches the store through the batching chat log: the read raced the writer and on CI lost, finding an empty thread. Close the log first, the way chatlog_test reads its thread back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1504: Skill suitability block leaks into visible transcript.
Findings & Changes
user.saidwhile the store/journal retains only the person's words, and the dimskills carriedline is the visible UI channel) already landed onorigin/devvia Hosted chat says it stopped while the run keeps running #1345.internal/session/skillturn_display_test.goverifying that the store transcript holds only user words while the model request receives the block.internal/manual/chat/skills-a-turn-used.md.docs/changes/unreleased/1504-transcript-keeps-your-words.md.Pre-existing Failure Root Cause & Resolution
internal/sessionpackage test failures:hears()test leak: lane-news sighting was leaking across tests; isolated the state.go test ./internal/session/...now runs with 0 failures (down from 2 on baseorigin/dev).—
Drafted with CodeAF · reviewed and owned by the author