fix: preserve first-party attribution in MCP discovery events - #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP discovery calls carrying valid first-party headers were still recorded as external when the client used a normal SDK identity. This caused our Google ADK TypeScript validation for google/adk-docs#2210 to add nine apparent external paid-offer exposures and one apparent new actor.
Validate classification once per MCP tool request and carry only the first-party flag and role into shared event recording. Keep the client handshake identity intact and reset the context after each call, including failures. Existing authentication and payment behavior are unchanged.
Add a read-time correction for the exact observed validation window (2026-09-08 13:16:45.477651–13:16:46.276347 UTC, MCPClient/1.0.0). Source events remain append-only and this generic SDK identity remains eligible outside that window. The eight separate agent-card entries have unresolved ownership and are not reclassified here.
Validation: