fix(core): harden local review runner output handling#2122
Open
christso wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AO-local review runs now fail when a reviewer exits without a structured JSON findings payload, instead of allowing empty output to become a clean review. The Codex reviewer invocation now runs with user config ignored, read-only sandboxing, approval disabled, and an output schema, which keeps configured MCP/GitHub/Agent Mail tooling out of the local review task. The output parser still salvages valid JSON from noisy process logs, so recoverable runs are not discarded just because stdout/stderr contain diagnostics.
Tests
pnpm --filter @aoagents/ao-core test -- code-review-manager.test.tspnpm --filter @aoagents/ao-cli test -- review.test.tspnpm --filter @aoagents/ao-cli test -- review-check.test.tspnpm --filter @aoagents/ao-core typecheckpnpm --filter @aoagents/ao-cli typecheckpnpm exec prettier --check packages/core/src/code-review-manager.ts packages/core/src/__tests__/code-review-manager.test.ts packages/core/src/index.ts