[stale] [poc] Enable turborepo remote cache#2939
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
GitHub CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Pull Request Overview
This PR enables turborepo remote caching for the project. The main changes include configuring remote cache settings in turbo.json, adding a turbo-cache service to docker-compose files, and making numerous code formatting adjustments (primarily reformatting multi-line assert statements and strings).
- Adds turborepo remote cache configuration with team slug and API URL
- Excludes
.next/cache/**from build outputs to avoid caching issues - Sets up turbo-cache Docker service using ducktors/turborepo-remote-cache:2.6.1
- Version changes from 0.62.1 to 0.62.0 (version rollback)
- Extensive code formatting changes (multi-line strings, assert statements, and line length adjustments)
Reviewed Changes
Copilot reviewed 256 out of 258 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web/turbo.json | Adds remoteCache configuration and updates build outputs |
| web/package.json, web/oss/package.json, web/ee/package.json | Version rollback to 0.62.0 |
| hosting/docker-compose/*/docker-compose.dev.yml | Adds turbo-cache service configuration |
| hosting/docker-compose//env..example | Adds turborepo environment variables |
| .turbo/config.json | New turbo configuration file |
| sdk/, api/ | Code formatting changes (assert statements, string formatting) |
| web/oss/src/components/.../JSONSchemaGenerator.ts | Renames "score" to "correctness" throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "remoteCache": { | ||
| "teamSlug":"agenta", | ||
| "apiUrl":"http://localhost:3040" | ||
| }, |
There was a problem hiding this comment.
The teamSlug property has inconsistent spacing. Add a space after the colon for consistency with JSON formatting conventions.
| { | ||
| "name": "agenta-web", | ||
| "version": "0.62.1", | ||
| "version": "0.62.0", |
There was a problem hiding this comment.
Version is being rolled back from 0.62.1 to 0.62.0. This is unusual for a feature addition PR and may cause confusion. Consider whether this version change is intentional or if it should be incremented instead.
| print( | ||
| f"{UNICODE['pipe']}" | ||
| f"{UNICODE['next' if testcase_idx < len(testcases) - 1 else 'last']}" | ||
| f"{UNICODE['next'if testcase_idx < len(testcases) - 1 else 'last']}" |
There was a problem hiding this comment.
Missing space after 'next' in the ternary expression. Should be 'next' if instead of 'next'if for better readability.
junaway
changed the title
junaway
changed the title
junaway
changed the title
3 participants
[PoC] Enabling turborepo remote cache