[AGE-2944] fix(frontend): add defensive checks for missing projectId in vault API calls#3634
Conversation
…in vault API calls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@mmabrouk -- there are conflicts |
@jp it because we had the check for fetches already? |
ardaerzin
left a comment
There was a problem hiding this comment.
we already have the check for fetch.
instead of doing this, I'd remove this project id read in the fetch function, and pass this value from the query atom and fix the projectId accessor there if it is not working as expected there
|
@jp-agenta @ardaerzin Sorry guys! Was going over linear today closing things and I stumbled upon this one (the 401) so I asked the Agent whether it was fixed and it came up with this simple fix, os I just went ahead |
…tore reads in vault api
Summary
projectIdis missing[]for fetch,nullfor mutations) instead of making invalid requests withproject_id=undefinedChanges
fetchVaultSecret: returns[]if no projectIdcreateVaultSecret: returnsnullif no projectIdupdateVaultSecret: returnsnullif no projectIddeleteVaultSecret: returnsnullif no projectIdCloses AGE-2944